Skip to content

Commit

Permalink
Merge pull request #37 from ingvagabund/scale-down-unneeded-time
Browse files Browse the repository at this point in the history
Allow to configure --scale-down-unneeded-time
  • Loading branch information
openshift-merge-robot committed Feb 9, 2019
2 parents d10deb8 + 9be773a commit 413f349
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/apis/autoscaling/v1alpha1/clusterautoscaler_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,5 @@ type ScaleDownConfig struct {
DelayAfterAdd string `json:"delayAfterAdd"`
DelayAfterDelete string `json:"delayAfterDelete"`
DelayAfterFailure string `json:"delayAfterFailure"`
UnneededTime string `json:"unneededTime,omitempty"`
}
5 changes: 5 additions & 0 deletions pkg/controller/clusterautoscaler/clusterautoscaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const (
ScaleDownDelayAfterAddArg AutoscalerArg = "--scale-down-delay-after-add"
ScaleDownDelayAfterDeleteArg AutoscalerArg = "--scale-down-delay-after-delete"
ScaleDownDelayAfterFailureArg AutoscalerArg = "--scale-down-delay-after-failure"
ScaleDownUnneededTimeArg AutoscalerArg = "--scale-down-unneeded-time"
MaxNodesTotalArg AutoscalerArg = "--max-nodes-total"
CoresTotalArg AutoscalerArg = "--cores-total"
MemoryTotalArg AutoscalerArg = "--memory-total"
Expand Down Expand Up @@ -96,6 +97,10 @@ func ScaleDownArgs(sd *v1alpha1.ScaleDownConfig) []string {
ScaleDownDelayAfterFailureArg.Value(sd.DelayAfterFailure),
}

if sd.UnneededTime != "" {
args = append(args, ScaleDownUnneededTimeArg.Value(sd.UnneededTime))
}

return args
}

Expand Down

0 comments on commit 413f349

Please sign in to comment.