Allow to configure --scale-down-unneeded-time #37
Conversation
openshift-ci-robot
added
the
size/XS
It takes 10 minutes before a cluster is scalled down (default value of --scale-down-unneeded-time). Allowing to override the option allows to decrease the time spend waiting on scale down operation in both testing and development environment. Also can help customer to scale down sooner.
ingvagabund
force-pushed
the
scale-down-unneeded-time
branch
from
15fd099
to
9be773a
Compare
| @@ -96,6 +97,10 @@ func ScaleDownArgs(sd *v1alpha1.ScaleDownConfig) []string { | |||
| ScaleDownDelayAfterFailureArg.Value(sd.DelayAfterFailure), | |||
| } | |||
|
|
|||
| if sd.UnneededTime != "" { | |||
There was a problem hiding this comment.
Let's also add a unit test case that validates a config with/without this value.
There was a problem hiding this comment.
We should actually probably add omitEmpty to all of the scale down argument fields in the resource, or even make them pointers. Then fix the Value() method here to return an empty string if it gets nil or an empty string. Not sure if we do that here or in a follow up.
There was a problem hiding this comment.
I would vote in a follow-up.
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
enxebre
removed
the
do-not-merge/hold
|
/approve |
ingvagabund
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
It takes 10 minutes before a cluster is scalled down (default value of --scale-down-unneeded-time).
Allowing to override the option allows to decrease the time spend waiting
on scale down operation in both testing and development environment.
Also can help customer to scale down sooner.