Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure metrics server #119

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Secure metrics server #119

merged 3 commits into from
Nov 12, 2019

Conversation

spangenberg
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2019
@spangenberg spangenberg force-pushed the secured-metrics branch 2 times, most recently from d8afe6a to cd3c7a0 Compare October 28, 2019 16:19
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2019
@spangenberg spangenberg force-pushed the secured-metrics branch 2 times, most recently from 0e975fe to ffadb0e Compare October 28, 2019 16:40
@enxebre
Copy link
Member

enxebre commented Oct 29, 2019

@spangenberg can we please make sure there's an e2e test that validates metrics are reported before merging this

@enxebre
Copy link
Member

enxebre commented Oct 29, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2019
@spangenberg spangenberg force-pushed the secured-metrics branch 2 times, most recently from e85fedc to 008e436 Compare October 30, 2019 15:07
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2019
@spangenberg spangenberg changed the title WIP: Secure metrics server Secure metrics server Oct 30, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2019
bison
bison approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@spangenberg
Copy link
Contributor Author

@enxebre just validated positively that the up{job="cluster-autoscaler-operator"} metric is always available.

@spangenberg
Copy link
Contributor Author

/hold cancel
/test e2e-aws

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

21 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7fc97e0 into openshift:master Nov 12, 2019
enxebre added a commit to enxebre/cluster-autoscaler-operator that referenced this pull request Nov 12, 2019
@enxebre
Drop alert temporary
88dc534 
This is breaking all CI due to alert being trieggered openshift#119
@enxebre enxebre mentioned this pull request Nov 12, 2019
Merged
wking added a commit to wking/cluster-autoscaler-operator that referenced this pull request Mar 22, 2021
@wking
install/90_alertruiles: Drop ClusterAutoscalerOperatorDown
684a918 
The cluster-version operator is responsible for complaining if the
autoscaler operator's deployment is sad, so no need for the operator
to handle this directly (we end up doubling up if there's an issue).
This drops the alert which was originally added in e1d8025 (Add
autoscaler down prometheus rule, 2019-11-05, openshift#119).
@wking wking mentioned this pull request Mar 22, 2021
Merged
wking added a commit to wking/cluster-autoscaler-operator that referenced this pull request Mar 22, 2021
@wking
install/90_alertrules: Drop ClusterAutoscalerOperatorDown
7bbbe72 
The cluster-version operator is responsible for complaining if the
autoscaler operator's deployment is sad, so no need for the operator
to handle this directly (we end up doubling up if there's an issue).
This drops the alert which was originally added in e1d8025 (Add
autoscaler down prometheus rule, 2019-11-05, openshift#119).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@bison bison bison approved these changes

@frobware frobware Awaiting requested review from frobware

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@bison bison

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spangenberg @enxebre @openshift-ci-robot @openshift-bot @bison @openshift-merge-robot