Bug 1861642: Add maxNodeProvisionTime for baremetal #158
Conversation
|
@hardys: This pull request references Bugzilla bug 1861642, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
|
I've tested this locally to confirm no regressions, but I can't see a way to get the new CRD definition - I guess the CVO has an old copy, any tips on how to work around that for local testing? |
|
@enxebre @JoelSpeed ptal |
|
/lgtm |
|
/test e2e-aws-operator |
|
I'm happy to approve this once the format is updated, apologies, literally found out there's a small bug in it earlier today 😅 |
In baremetal environments it can easily take longer than the CA default of 15mins for the node to become active after a scale-out action. The CA supports --max-node-provision-time[1] so adding support to enable configuration of that value should allow tuning of the time such that it's more suited to baremetal. Accepted review suggestion to fix bug in regex Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk> [1] https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#what-are-the-parameters-to-ca
|
/test e2e-aws-operator |
Add review suggestion Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws |
|
/test e2e-aws |
|
@elmiko - please could you revisit this when you get a moment - thanks! :) |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@hardys: All pull requests linked via external trackers have merged: openshift/cluster-autoscaler-operator#158. Bugzilla bug 1861642 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In baremetal environments it can easily take longer than the CA
default of 15mins for the node to become active after a scale-out
action.
The CA supports --max-node-provision-time[1] so adding support to
enable configuration of that value should allow tuning of the
time such that it's more suited to baremetal.
[1] https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#what-are-the-parameters-to-ca