Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1861642: Add maxNodeProvisionTime for baremetal #158

Merged
merged 2 commits into from Aug 12, 2020

Commits on Aug 5, 2020

  1. Bug 1861642: Add maxNodeProvisionTime for baremetal

    In baremetal environments it can easily take longer than the CA
    default of 15mins for the node to become active after a scale-out
    action.
    
    The CA supports --max-node-provision-time[1] so adding support to
    enable configuration of that value should allow tuning of the
    time such that it's more suited to baremetal.
    
    Accepted review suggestion to fix bug in regex
    Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
    
    [1] https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#what-are-the-parameters-to-ca
    Steven Hardy committed Aug 5, 2020
    Copy the full SHA
    6cde7f9 View commit details
    Browse the repository at this point in the history
  2. Update pkg/apis/autoscaling/v1/clusterautoscaler_types.go

    Add review suggestion
    
    Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
    Steven Hardy and JoelSpeed committed Aug 5, 2020
    Copy the full SHA
    283a1c7 View commit details
    Browse the repository at this point in the history