Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controller-runtime version to v0.8.3 #137

Merged
merged 1 commit into from Jun 24, 2021
Merged

Update controller-runtime version to v0.8.3 #137

merged 1 commit into from Jun 24, 2021

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented Apr 29, 2021

Some recent fixes in controller-runtime might be useful for us. Especially the one regarding adding a timeout while waiting for the cache to sync.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@sadasu
Copy link
Contributor Author

sadasu commented Apr 29, 2021

/retest

1 similar comment
@sadasu
Copy link
Contributor Author

sadasu commented Apr 29, 2021

/retest

@asalkeld
Copy link
Contributor

will make a conflict with mine, but otherwise seems like a good idea if we don't merge my one.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2021
@sadasu sadasu force-pushed the update-controller-runtime branch from 259a53a to 9c911e0 Compare May 10, 2021 15:01
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu sadasu force-pushed the update-controller-runtime branch 3 times, most recently from 9c986ad to 41313eb Compare May 10, 2021 15:49
@sadasu sadasu force-pushed the update-controller-runtime branch from 41313eb to 8cef077 Compare May 26, 2021 20:53
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2021
@sadasu
Copy link
Contributor Author

sadasu commented May 27, 2021

/retest

1 similar comment
@asalkeld
Copy link
Contributor

asalkeld commented Jun 7, 2021

/retest

@asalkeld
Copy link
Contributor

/title Update controller-runtime version to v0.8.3

asalkeld
asalkeld reviewed Jun 22, 2021
View reviewed changes
Copy link
Contributor

@asalkeld asalkeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@sadasu sadasu changed the title WIP: Update controller-runtime version to v0.8.3 Update controller-runtime version to v0.8.3 Jun 23, 2021
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 23, 2021
@sadasu sadasu force-pushed the update-controller-runtime branch from 8cef077 to fb6618e Compare June 23, 2021 13:27
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 23, 2021
@sadasu
Copy link
Contributor Author

sadasu commented Jun 23, 2021

/test e2e-metal-ipi

@sadasu
Copy link
Contributor Author

sadasu commented Jun 23, 2021

/test e2e-metal-ipi-ovn-ipv6

@asalkeld
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@sadasu
Copy link
Contributor Author

sadasu commented Jun 24, 2021

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3ded234 into openshift:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalkeld asalkeld asalkeld left review comments

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

@asalkeld asalkeld

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sadasu @openshift-ci-robot @asalkeld @openshift-bot @openshift-merge-robot