-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update controller-runtime version to v0.8.3 #137
Update controller-runtime version to v0.8.3 #137
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
will make a conflict with mine, but otherwise seems like a good idea if we don't merge my one. |
259a53a
to
9c911e0
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9c986ad
to
41313eb
Compare
41313eb
to
8cef077
Compare
/retest |
1 similar comment
/retest |
/title Update controller-runtime version to v0.8.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
8cef077
to
fb6618e
Compare
/test e2e-metal-ipi |
/test e2e-metal-ipi-ovn-ipv6 |
/lgtm |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Some recent fixes in controller-runtime might be useful for us. Especially the one regarding adding a timeout while waiting for the cache to sync.