Pass the node mac addresses to containers currently needing provisioningInterface #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
approved
asalkeld
force-pushed
the
mac-not-interface-name
branch
from
eb4d74e
to
920c1b9
Compare
asalkeld
force-pushed
the
mac-not-interface-name
branch
from
920c1b9
to
47ec5d7
Compare
asalkeld
force-pushed
the
mac-not-interface-name
branch
from
47ec5d7
to
034780b
Compare
squidboylan
reviewed
Jun 2, 2021
| @@ -51,7 +51,7 @@ spec: | |||
| - Disabled | |||
| type: string | |||
| provisioningNetworkCIDR: | |||
| description: ProvisioningNetworkCIDR is the network on which the baremetal nodes are provisioned. The provisioningIP and the IPs in the dhcpRange all come from within this network. IPv6 networks cannot be larger than a /64. | |||
There was a problem hiding this comment.
Is there a reason this was removed? Maybe just a mistake during a merge conflict?
There was a problem hiding this comment.
the version of controller-gen was bumped because of needing to import baremetal operator and this changed because of the controller-gen bump
858ecb6
asalkeld
force-pushed
the
mac-not-interface-name
branch
from
034780b
to
858ecb6
Compare
|
/retest |
asalkeld
force-pushed
the
mac-not-interface-name
branch
from
858ecb6
to
e0e1622
Compare
|
/retest |
asalkeld
force-pushed
the
mac-not-interface-name
branch
from
e0e1622
to
b7801bb
Compare
|
/retest |
asalkeld
force-pushed
the
mac-not-interface-name
branch
2 times, most recently
from
33379f3
to
ce3b187
Compare
…ingInterface Since we don't know what node it will be started on, pass all master node macs in the env as PROVISIONING_MACS=mac1,mac2,mac3
asalkeld
force-pushed
the
mac-not-interface-name
branch
from
ce3b187
to
adbd55e
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asalkeld, kirankt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
hardys
pushed a commit
to hardys/cluster-baremetal-operator
that referenced
this pull request
Jul 22, 2021
This was added for refresh-static-ips in openshift#149 - but actually the point where we really need it is the initial setting of the IP since the underlying script can't detect which interface to use by IP until it's configured.
hardys
pushed a commit
to hardys/cluster-baremetal-operator
that referenced
this pull request
Jul 22, 2021
This was added for refresh-static-ips in openshift#149 - but actually the point where we really need it is the initial setting of the IP since the underlying script can't detect which interface to use by IP until it's configured.
asalkeld
pushed a commit
to asalkeld/cluster-baremetal-operator
that referenced
this pull request
Jul 26, 2021
This was added for refresh-static-ips in openshift#149 - but actually the point where we really need it is the initial setting of the IP since the underlying script can't detect which interface to use by IP until it's configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't know what node it will be started on, pass all master node macs in the env as PROVISIONING_MACS
/hold