Set external IP env var for ironic conductor too. #176
Conversation
We need to set this for ironic conductor also as it is the thing responsible for setting up the callback.
|
/test e2e-metal-ipi |
|
/assign @asalkeld |
|
any chance of some unit tests while you are at it? We are short on them.. |
| @@ -607,6 +607,7 @@ func createContainerMetal3IronicConductor(images *Images, config *metal3iov1alph | |||
| buildEnvVar(provisioningInterface, config), | |||
| buildSSHKeyEnvVar(sshKey), | |||
| setIronicHtpasswdHash(htpasswdEnvVar, ironicrpcSecretName), | |||
| setIronicExternalIp(externalIpEnvVar, config), | |||
There was a problem hiding this comment.
I'm not clear why this isn't being done through buildEnvVar, but it matches the one for ironic-api.
There was a problem hiding this comment.
It looks like because there is some additional logic around Disabled provisioning network, and AFAICS the conditional in buildEnvVar only handles PROVISIONING_IP not IRONIC_EXTERNAL_IP
Maybe that can be refactored in future, but as you say this looks Ok for now?
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys, imain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
We need to set this for ironic conductor also as it is the thing
responsible for setting up the callback.