Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set external IP env var for ironic conductor too. #176

Merged
merged 1 commit into from Jul 23, 2021
Merged

Set external IP env var for ironic conductor too. #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions provisioning/baremetal_pod.go
View file
Open in desktop
Expand Up @@ -607,6 +607,7 @@ func createContainerMetal3IronicConductor(images *Images, config *metal3iov1alph
buildEnvVar(provisioningInterface, config),
buildSSHKeyEnvVar(sshKey),
setIronicHtpasswdHash(htpasswdEnvVar, ironicrpcSecretName),
setIronicExternalIp(externalIpEnvVar, config),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear why this isn't being done through buildEnvVar, but it matches the one for ironic-api.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like because there is some additional logic around Disabled provisioning network, and AFAICS the conditional in buildEnvVar only handles PROVISIONING_IP not IRONIC_EXTERNAL_IP

Maybe that can be refactored in future, but as you say this looks Ok for now?

},
Ports: []corev1.ContainerPort{
{
Expand Down