OCPBUGS-1239: do not rely on string "master" to be in BMH names

[dtantsur]

We're currently detecting control plane nodes by "master" in their BMH
names. This is not reliable. Use a nodes filter instead.

(cherry picked from commit b9a929a)

[openshift-ci-robot]

@dtantsur: This pull request references Jira Issue OCPBUGS-1239, which is invalid:

• expected dependent Jira Issue OCPBUGS-747 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

We're currently detecting control plane nodes by "master" in their BMH
names. This is not reliable. Use a nodes filter instead.

(cherry picked from commit b9a929a)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dtantsur: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-1239: do not rely on string "master" to be in BMH names

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dtantsur]

/label backport-risk-assessed

[dtantsur]

/test e2e-agnostic

[honza]

/lgtm

[dtantsur]

/jira refresh

[openshift-ci-robot]

@dtantsur: This pull request references Jira Issue OCPBUGS-1239, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.10.z) matches configured target version for branch (4.10.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-747 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-747 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[honza]

/label cherry-pick-approved

[openshift-ci]

@honza: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[honza]

/assign @pamoedom

[pamoedom]

/assign @jadhaj

[openshift-ci]

@dtantsur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi	6d95754	link	true	/test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jadhaj]

/label cherry-pick-approved

[dtantsur]

/test e2e-agnostic

[openshift-ci-robot]

@dtantsur: All pull requests linked via external trackers have merged:

• openshift/cluster-baremetal-operator#287

Jira Issue OCPBUGS-1239 has been moved to the MODIFIED state.

In response to this:

We're currently detecting control plane nodes by "master" in their BMH
names. This is not reliable. Use a nodes filter instead.

(cherry picked from commit b9a929a)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.