OCPBUGS-23131,OCPBUGS-23149: fix IRONIC_EXTERNAL_URL_V6

[dtantsur]

IRONIC_EXTERNAL_URL_V6 is currently calculated incorrectly:

1. It uses the API VIP, but the Ironic's httpd is not proxied in the
   same way as Ironic itself and thus may not be available there.
2. It uses an external IP even when a provisioning network is enabled
   and VirtualMediaViaExternalNetwork is false.

This change fixes both issues, while also cleaning up the provisioning
utils to ensure all functions are dualstack-aware. The split between
the BMO and Metal3 pods is an implicit requirement of this change.

This change does NOT fix the fact that ICC is not configured correctly
for deploying IPv6-only nodes from a dualstack cluster.

[openshift-ci-robot]

@dtantsur: This pull request references Jira Issue OCPBUGS-23131, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

IRONIC_EXTERNAL_URL_V6 is currently calculated incorrectly:

1. It uses the API VIP, but the Ironic's httpd is not proxied in the
   same way as Ironic itself and thus may not be available there.
2. It uses an external IP even when a provisioning network is enabled
   and VirtualMediaViaExternalNetwork is false.

This change fixes both issues, while also cleaning up the provisioning
utils to ensure all functions are dualstack-aware. The split between
the BMO and Metal3 pods is an implicit requirement of this change.

This change does NOT fix the fact that ICC is not configured correctly
for deploying IPv6-only nodes from a dualstack cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@dtantsur: This pull request references Jira Issue OCPBUGS-23131, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-23149, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

IRONIC_EXTERNAL_URL_V6 is currently calculated incorrectly:

1. It uses the API VIP, but the Ironic's httpd is not proxied in the
   same way as Ironic itself and thus may not be available there.
2. It uses an external IP even when a provisioning network is enabled
   and VirtualMediaViaExternalNetwork is false.

This change fixes both issues, while also cleaning up the provisioning
utils to ensure all functions are dualstack-aware. The split between
the BMO and Metal3 pods is an implicit requirement of this change.

This change does NOT fix the fact that ICC is not configured correctly
for deploying IPv6-only nodes from a dualstack cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtantsur]

/retest

[dtantsur]

/retest

[openshift-ci]

@dtantsur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-sdn-upgrade	f9fd3fd	link	false	/test e2e-metal-ipi-sdn-upgrade
ci/prow/e2e-metal-ipi-upgrade-ovn-ipv6	f9fd3fd	link	false	/test e2e-metal-ipi-upgrade-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dtantsur]

/label acknowledge-critical-fixes-only

Fixes a regression in IPv6 support on dualstack.

[elfosardo]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9178df0 and 2 for PR HEAD f9fd3fd in total

[openshift-ci-robot]

@dtantsur: Jira Issue OCPBUGS-23131: All pull requests linked via external trackers have merged:

• openshift/cluster-baremetal-operator#380

Jira Issue OCPBUGS-23131 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-23149: All pull requests linked via external trackers have merged:

• openshift/cluster-baremetal-operator#380

Jira Issue OCPBUGS-23149 has been moved to the MODIFIED state.

In response to this:

IRONIC_EXTERNAL_URL_V6 is currently calculated incorrectly:

1. It uses the API VIP, but the Ironic's httpd is not proxied in the
   same way as Ironic itself and thus may not be available there.
2. It uses an external IP even when a provisioning network is enabled
   and VirtualMediaViaExternalNetwork is false.

This change fixes both issues, while also cleaning up the provisioning
utils to ensure all functions are dualstack-aware. The split between
the BMO and Metal3 pods is an implicit requirement of this change.

This change does NOT fix the fact that ICC is not configured correctly
for deploying IPv6-only nodes from a dualstack cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-baremetal-operator-container-v4.15.0-202311161952.p0.gbcbd01b.assembly.stream for distgit ose-cluster-baremetal-operator.
All builds following this will include this PR.

[dtantsur]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@dtantsur: new pull request created: #384

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-11-17-103843