New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-17354: Update CBO to support dual stack SNO hub deploying an IPv6 spoke #6113
MGMT-17354: Update CBO to support dual stack SNO hub deploying an IPv6 spoke #6113
Conversation
This includes openshift/cluster-baremetal-operator#380 which is required for a single stack ipv6 cluster to be deployed from a dual-stack hub when the hub is a single node. https://issues.redhat.com/browse/MGMT-17354
@carbonin: This pull request references MGMT-17354 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@carbonin: This pull request references MGMT-17354 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6113 +/- ##
==========================================
+ Coverage 68.31% 68.33% +0.02%
==========================================
Files 242 242
Lines 35788 35804 +16
==========================================
+ Hits 24447 24467 +20
+ Misses 9216 9214 -2
+ Partials 2125 2123 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
dev script failed |
Looks like these tests should be fixed by #6116 |
/retest-required |
@carbonin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
00a203b
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202403280418.p0.g00a203b.assembly.stream.el8 for distgit ose-agent-installer-api-server. |
/cherry-pick release-ocm-2.10 |
@carbonin: new pull request created: #6121 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updates CBO to include openshift/cluster-baremetal-operator#380 which is required for a single stack ipv6 cluster to be deployed from a dual-stack hub when the hub is a single node.
List all the issues related to this PR
https://issues.redhat.com/browse/MGMT-17354
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist