Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow desc:ns/pod-prefix,ns/pod-prefix syntax for required pods #8

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jan 21, 2019

This is necessary during pod renames, to accept different pod name prefixes during the transition.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2019
@sttts sttts changed the title Allow desc:ns/pod-prefix syntax for required pods Allow desc:ns/pod-prefix,ns/pod-prefix syntax for required pods Jan 21, 2019
@sttts
Copy link
Contributor Author

sttts commented Jan 21, 2019

/assign @deads2k

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2019
smarterclayton added a commit to smarterclayton/ci-operator that referenced this pull request Jan 21, 2019
Currently we report:

    openshift.io/description: |-
      pull-ci-openshift-cluster-bootstrap-master-verify-deps on https://github.com/openshift/cluster-bootstrap

      openshift/cluster-bootstrap#8 - sttts

but reporting

    openshift.io/description: |-
      openshift/cluster-bootstrap#8 - sttts

      pull-ci-openshift-cluster-bootstrap-master-verify-deps on https://github.com/openshift/cluster-bootstrap

is more readable (user can instantly link to the PR that triggered the job), and the extra info is redundant
or debug only.
@sttts sttts closed this Jan 25, 2019
@sttts sttts deleted the sttts-disjunctions branch January 25, 2019 16:36
@sttts sttts restored the sttts-disjunctions branch January 26, 2019 09:03
@sttts sttts reopened this Jan 26, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2019
@sttts
Copy link
Contributor Author

sttts commented Feb 1, 2019

/retest

@openshift-ci-robot openshift-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 4, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2019

@sttts: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-operator 2c8b832 link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Contributor Author

sttts commented Feb 4, 2019

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Feb 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4aaf533 into openshift:master Feb 5, 2019
@sttts sttts deleted the sttts-disjunctions branch April 2, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants