Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add excludeMasterFromStandardLB param to cloud-config on Azure platform #102

Closed
wants to merge 2 commits into from
Closed

Conversation

lobziik
Copy link
Contributor

@lobziik lobziik commented Jul 28, 2021

Do not merge please. Intented to check if e2e tests will pass successfull with that on Azure.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from lobziik after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from elmiko and mdbooth July 28, 2021 09:30
@lobziik
Copy link
Contributor Author

lobziik commented Jul 28, 2021

/test e2e-azure-ccm

@lobziik
Copy link
Contributor Author

lobziik commented Jul 28, 2021

/test e2e-azure-ccm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@lobziik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade e2afc50 link /test e2e-aws-upgrade
ci/prow/e2e-aws-ccm-install e2afc50 link /test e2e-aws-ccm-install
ci/prow/e2e-aws-ccm e2afc50 link /test e2e-aws-ccm
ci/prow/e2e-azure-ccm e2afc50 link /test e2e-azure-ccm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

@lobziik Shall we close this now that openshift/installer#5111 has merged?

@lobziik
Copy link
Contributor Author

lobziik commented Jul 29, 2021

Yup, we do not need it anymore. /close

@JoelSpeed JoelSpeed closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants