Bug 1987083: Azure: cloud provider config excludeMastersFromStandardLB -> false #5111
Conversation
|
@patrickdillon: This pull request references Bugzilla bug 1987083, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-unspecified
|
/bugzilla refresh |
|
/test e2e-azure |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/severity-high
|
@patrickdillon: This pull request references Bugzilla bug 1987083, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
|
/lgtm |
This updates the Azure cloud provider config to set excludeMastersFromStandardLB to false. The default value is true, which has not been a problem because the functionality was broken. With the move to out-of-tree providers the functionality has been restored, in which case if a master node restarts the service controller will not add it back to the load balancer backend pool.
patrickdillon
force-pushed
the
azure-cloud-config-exclude-masters
branch
from
6c684d2
to
79f2e2e
Compare
|
Woops. I overlooked the unit test. Fixed now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-azure |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Thanks @patrickdillon /lgtm |
|
@patrickdillon: All pull requests linked via external trackers have merged: Bugzilla bug 1987083 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This updates the Azure cloud provider config to set excludeMastersFromStandardLB to false. The default value is true, which
has not been a problem because the functionality was broken. With the move to out-of-tree providers the functionality has been restored, in which case if a master node restarts the service controller will not add it back to the load balancer backend pool.
cc @JoelSpeed @lobziik