Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme. Add links to CCMs repos. #112

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Update readme. Add links to CCMs repos. #112

merged 2 commits into from
Sep 14, 2021

Conversation

lobziik
Copy link
Contributor

@lobziik lobziik commented Aug 31, 2021

Add links to CCMs repos.
Change Azure ci status.

@lobziik
Copy link
Contributor Author

lobziik commented Aug 31, 2021

/hold

till 4.10 will be open

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2021
README.md Outdated
| [AWS](https://github.com/openshift/cloud-provider-aws) | Yes | Yes |
| [Azure](https://github.com/openshift/cloud-provider-azure) | Yes | Yes |
| [GCP](https://github.com/openshift/cloud-provider-gcp) | No | |
| [OpenStack](https://github.com/openshift/cloud-provider-openstack) | Yes | No |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have OpenStack tests now

README.md Outdated
| [Azure](https://github.com/openshift/cloud-provider-azure) | Yes | Yes |
| [GCP](https://github.com/openshift/cloud-provider-gcp) | No | |
| [OpenStack](https://github.com/openshift/cloud-provider-openstack) | Yes | No |
| [vSphere](https://github.com/openshift/cloud-provider-vsphere) | No | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about adding IBM Cloud and Alibaba here?

@lobziik lobziik requested a review from Fedosin September 6, 2021 15:40
@lobziik
Copy link
Contributor Author

lobziik commented Sep 6, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2021
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2021
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this change, just a minor suggestion to make it more consistent

README.md Outdated
@@ -43,7 +45,7 @@ cluster bootstrapping and initial payload deployment. In general, it is best
to allow the OpenShift installer to manage its operation.

To better understand how this operator is deployed, please see the
[`manifest`](/manifest) directory. It contains a series of Kubernetes
[`manifest`](/manifests) directory. It contains a series of Kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are calling out the directory name explicitly, the link should have the same name

Suggested change
[`manifest`](/manifests) directory. It contains a series of Kubernetes
[`manifests`](/manifests) directory. It contains a series of Kubernetes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Add links to cloud provider repos, update ci statuses.
Fix manifests link.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@lobziik lobziik requested a review from elmiko September 14, 2021 10:54
Mark IBM provider as included into operator
Copy link

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

@lobziik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ccm 585e0c0 link /test e2e-azure-ccm
ci/prow/e2e-azure 585e0c0 link /test e2e-azure
ci/prow/e2e-azure-ccm-install 585e0c0 link /test e2e-azure-ccm-install
ci/prow/e2e-azure-upgrade 585e0c0 link /test e2e-azure-upgrade
ci/prow/e2e-openstack-ccm a63aaa8 link false /test e2e-openstack-ccm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 47548be into openshift:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants