-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme. Add links to CCMs repos. #112
Conversation
/hold till 4.10 will be open |
README.md
Outdated
| [AWS](https://github.com/openshift/cloud-provider-aws) | Yes | Yes | | ||
| [Azure](https://github.com/openshift/cloud-provider-azure) | Yes | Yes | | ||
| [GCP](https://github.com/openshift/cloud-provider-gcp) | No | | | ||
| [OpenStack](https://github.com/openshift/cloud-provider-openstack) | Yes | No | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have OpenStack tests now
README.md
Outdated
| [Azure](https://github.com/openshift/cloud-provider-azure) | Yes | Yes | | ||
| [GCP](https://github.com/openshift/cloud-provider-gcp) | No | | | ||
| [OpenStack](https://github.com/openshift/cloud-provider-openstack) | Yes | No | | ||
| [vSphere](https://github.com/openshift/cloud-provider-vsphere) | No | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about adding IBM Cloud and Alibaba here?
/hold cancel |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like this change, just a minor suggestion to make it more consistent
README.md
Outdated
@@ -43,7 +45,7 @@ cluster bootstrapping and initial payload deployment. In general, it is best | |||
to allow the OpenShift installer to manage its operation. | |||
|
|||
To better understand how this operator is deployed, please see the | |||
[`manifest`](/manifest) directory. It contains a series of Kubernetes | |||
[`manifest`](/manifests) directory. It contains a series of Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are calling out the directory name explicitly, the link should have the same name
[`manifest`](/manifests) directory. It contains a series of Kubernetes | |
[`manifests`](/manifests) directory. It contains a series of Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Add links to cloud provider repos, update ci statuses. Fix manifests link.
Mark IBM provider as included into operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demichev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lobziik: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
Add links to CCMs repos.
Change Azure ci status.