Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2037680: Fix CCCMO metric ports configuration #164

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Bug 2037680: Fix CCCMO metric ports configuration #164

merged 1 commit into from
Jan 6, 2022

Conversation

lobziik
Copy link
Contributor

@lobziik lobziik commented Jan 6, 2022

Disable redundant config-sync-controller metrics server,
change health check port from 9259 to 9260.
Reassign mistakenly exposed ports from config-sync-controller to operator.

Also need add 9260 port here: https://github.com/openshift/enhancements/blob/master/dev-guide/host-port-registry.md as localhost only

P.S openshift/enhancements#997

Disable redundant config-sync-controller metrics server,
change health check port from 9259 to 9260.
Reassign mistakenly exposed ports from config-sync-controller to operator.
@openshift-ci OpenShift CI bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 6, 2022
@openshift-ci
Copy link
Contributor

OpenShift CI bot commented Jan 6, 2022

@lobziik: This pull request references Bugzilla bug 2037680, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2037680: Fix CCCMO metric ports configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

OpenShift CI bot commented Jan 6, 2022

@lobziik: This pull request references Bugzilla bug 2037680, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2037680: Fix CCCMO metric ports configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @lobziik

@openshift-ci
Copy link
Contributor

OpenShift CI bot commented Jan 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

OpenShift CI bot commented Jan 6, 2022

@lobziik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 07cc7d7 link false /test e2e-azure
ci/prow/e2e-azure-upgrade 07cc7d7 link false /test e2e-azure-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 98b7142 into openshift:master Jan 6, 2022
@openshift-ci
Copy link
Contributor

OpenShift CI bot commented Jan 6, 2022

@lobziik: All pull requests linked via external trackers have merged:

Bugzilla bug 2037680 has been moved to the MODIFIED state.

In response to this:

Bug 2037680: Fix CCCMO metric ports configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants