Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator deployment #3

Merged
merged 4 commits into from Jan 19, 2021
Merged

Operator deployment #3

merged 4 commits into from Jan 19, 2021

Conversation

Danil-Grigorev
Copy link
Contributor

Manifest for image referencing and operator deployment, which will be later populated by CI.

To test image in production here is a temporary operator image location quay.io/dgrigore/cluster-cloud-controller-manager-operator:latest.

JoelSpeed
JoelSpeed reviewed Jan 18, 2021
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the directory be called manifests or install? It's install in MAO and CAO 🤔

manifests/0000_26_cloud-controller-manager-operator_11_deployment.yaml
labels:
k8s-app: cloud-manager-operator
spec:
priorityClassName: system-node-critical
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the options here? Does this mean this component is critical if we want nodes to work correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to doc there are a couple. I'm following the practices of both MAO and KCM here as we fall under master-controller category.

@Danil-Grigorev
Copy link
Contributor Author

I feel like manifests is a better variant from those two. It is used mostly anywhere: https://github.com/openshift/cluster-kube-controller-manager-operator/tree/master/manifests

@JoelSpeed
Copy link
Contributor

So long as the manifests can be picked up in the release payload I'm happy
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2021
Fedosin
Fedosin approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@Danil-Grigorev
Copy link
Contributor Author

/test vendor

@Fedosin
Copy link
Contributor

Fedosin commented Jan 19, 2021

/refresh

@Fedosin
Copy link
Contributor

Fedosin commented Jan 19, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit d7f12d6 into openshift:master Jan 19, 2021
@Fedosin Fedosin mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Fedosin approved these changes

@mandre mandre Awaiting requested review from mandre

@mdbooth mdbooth Awaiting requested review from mdbooth

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Danil-Grigorev @JoelSpeed @openshift-ci-robot @Fedosin @openshift-merge-robot