Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image-references #77

Merged
merged 1 commit into from Aug 6, 2022
Merged

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Aug 4, 2022

To allow CPMS operator to be installed by CVO we need to create an
image-references file.

For more information:
https://github.com/openshift/enhancements/blob/master/dev-guide/cluster-version-operator/dev/operators.md#how-do-i-ensure-the-right-images-get-used-by-my-manifests

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 4, 2022
@openshift-ci openshift-ci bot requested review from damdo and JoelSpeed August 4, 2022 11:04
@JoelSpeed
Copy link
Contributor

/hold

It's my understanding that we need to have the images in payload before we add an image reference, so lets make sure we are doing that and then we can proceed to work out why the CPMSO isn't being deployed

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2022
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 4, 2022

@JoelSpeed, no, it's not related... For instance, for CCCMO we created the file on Jan 19, 2021: openshift/cluster-cloud-controller-manager-operator#3 but the image was added 6 months later, on Jun 18, 2021: openshift-eng/ocp-build-data#936

@JoelSpeed
Copy link
Contributor

/hold cancel
/approve
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2022
@JoelSpeed
Copy link
Contributor

I still don't see the operator being deployed in the CI builds though, any ideas?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 5, 2022

We need to merge it first. On the next CI run we will see the image deployed.

@JoelSpeed
Copy link
Contributor

Changes in a PR should have an effect on the CI before they are merged, I'm not sure what you're saying is true here

@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 5, 2022

/test e2e-aws-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

@Fedosin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 84f0f76 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 5d9e548 and 8 for PR HEAD 84f0f76 in total

@openshift-ci openshift-ci bot merged commit b131c69 into openshift:main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants