Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1378: Revert #304 "Undo TRT-1374: Revert for \"OCPCLOUD-2278: Add kube-rbac-proxy container & ensure metrics are only available via HTTPS\"" #305

Merged
merged 1 commit into from Dec 2, 2023
Merged

TRT-1378: Revert #304 "Undo TRT-1374: Revert for \"OCPCLOUD-2278: Add kube-rbac-proxy container & ensure metrics are only available via HTTPS\"" #305

merged 1 commit into from Dec 2, 2023

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Dec 2, 2023 •
edited

Reverts #304 ; tracked by TRT-1378

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Metal jobs failing with errors on pulling kube-rbac-proxy: event happened 374 times, something is wrong: namespace/openshift-cloud-controller-manager-operator node/master-1.ostest.test.metalkube.org pod/cluster-cloud-controller-manager-operator-5b6b87b648-rzdbc hmsg/873af7a9ec - reason/BackOff Back-off pulling image quay.io/openshift/origin-kube-rbac-proxy:4.2.0

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6/1730741227965386752

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test the full 4.15 nightly blocking jobs on unrevert

CC: @racheljpg, @JoelSpeed

PR created by Revertomatic™️

@stbenjam
Revert "Merge pull request openshift#304 from racheljpg/unrevertconta…
43387bd 
…iner"

This reverts commit e6cba2b, reversing
changes made to b8e6751.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2023 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1378 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #304 ; tracked by TRT-1378

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Metal jobs failing with errors on pulling kube-rbac-proxy: event happened 374 times, something is wrong: namespace/openshift-cloud-controller-manager-operator node/master-1.ostest.test.metalkube.org pod/cluster-cloud-controller-manager-operator-5b6b87b648-rzdbc hmsg/873af7a9ec - reason/BackOff Back-off pulling image quay.io/openshift/origin-kube-rbac-proxy:4.2.0

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test the full 4.15 nightly blocking jobs on unrevert

CC: @racheljpg

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2023 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1378 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #304 ; tracked by TRT-1378

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Metal jobs failing with errors on pulling kube-rbac-proxy: event happened 374 times, something is wrong: namespace/openshift-cloud-controller-manager-operator node/master-1.ostest.test.metalkube.org pod/cluster-cloud-controller-manager-operator-5b6b87b648-rzdbc hmsg/873af7a9ec - reason/BackOff Back-off pulling image quay.io/openshift/origin-kube-rbac-proxy:4.2.0

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test the full 4.15 nightly blocking jobs on unrevert

CC: @racheljpg, @JoelSpeed

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented Dec 2, 2023

/override ci/prow/e2e-gcp-ovn-ccm
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-alibaba-ovn
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-gcp-ovn-techpreview
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-azure-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/skip
/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2023 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1378 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #304 ; tracked by TRT-1378

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Metal jobs failing with errors on pulling kube-rbac-proxy: event happened 374 times, something is wrong: namespace/openshift-cloud-controller-manager-operator node/master-1.ostest.test.metalkube.org pod/cluster-cloud-controller-manager-operator-5b6b87b648-rzdbc hmsg/873af7a9ec - reason/BackOff Back-off pulling image quay.io/openshift/origin-kube-rbac-proxy:4.2.0

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27231/pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6/1730718245385670656

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test the full 4.15 nightly blocking jobs on unrevert

CC: @racheljpg, @JoelSpeed

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 2, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-alibaba-ovn, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-azure-ovn, ci/prow/e2e-azure-ovn-upgrade, ci/prow/e2e-gcp-ovn-ccm, ci/prow/e2e-gcp-ovn-techpreview, ci/prow/e2e-openstack-ovn, ci/prow/e2e-vsphere-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn-ccm
/override ci/prow/e2e-azure-ovn-upgrade
/override ci/prow/e2e-alibaba-ovn
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-gcp-ovn-techpreview
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-openstack-ovn
/override ci/prow/e2e-azure-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/skip
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2023 •
edited by openshift-ci bot

@stbenjam: This pull request references TRT-1378 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #304 ; tracked by TRT-1378

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Metal jobs failing with errors on pulling kube-rbac-proxy: event happened 374 times, something is wrong: namespace/openshift-cloud-controller-manager-operator node/master-1.ostest.test.metalkube.org pod/cluster-cloud-controller-manager-operator-5b6b87b648-rzdbc hmsg/873af7a9ec - reason/BackOff Back-off pulling image quay.io/openshift/origin-kube-rbac-proxy:4.2.0

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6/1730741227965386752

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Please test the full 4.15 nightly blocking jobs on unrevert

CC: @racheljpg, @JoelSpeed

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking
wking approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2023
@stbenjam
Copy link
Member Author

stbenjam commented Dec 2, 2023

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit dd0785d into openshift:master Dec 2, 2023
16 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 2, 2023

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking mentioned this pull request Dec 2, 2023
Merged
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.15.0-202312020907.p0.gdd0785d.assembly.stream for distgit ose-cluster-cloud-controller-manager-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stbenjam @openshift-ci-robot @openshift-bot @wking