Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-362: pkg/monitortests/clusterversionoperator: Fatal unless Available=False in allow-list #27231

Merged
merged 17 commits into from Dec 3, 2023

Conversation

wking
Copy link
Member

@wking wking commented Jun 8, 2022

Filling in known bugs from here (WIP: not actually full yet). This allows us to fail new regressions, and gradually ratchet tighter as we close out existing issues.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2022
@openshift-ci openshift-ci bot requested review from jwforres and spadgett June 8, 2022 00:08
@wking
Copy link
Member Author

wking commented Jun 8, 2022

Success:

image

I'll expand the exception list...

@wking wking changed the title WIP: pkg/synthetictests/operators: Fatal unless Available=False in allow-list pkg/synthetictests/operators: Fatal unless Available=False in allow-list Jun 8, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2022
@wking
Copy link
Member Author

wking commented Jun 8, 2022

WIP: not actually full yet

I've filled in the list of regexps in 78c5e91, so dropping the WIP.

@wking wking force-pushed the fatal-available-false branch 2 times, most recently from 6dc7c2b to bedc17e Compare June 8, 2022 23:19
@wking
Copy link
Member Author

wking commented Jun 9, 2022

New phrasing:

image

@wking wking force-pushed the fatal-available-false branch 2 times, most recently from 8c71586 to 054f30d Compare June 9, 2022 14:04
regexp.MustCompile(".*clusteroperator/kube-storage-version-migrator condition/Available status/False reason/KubeStorageVersionMigratorAvailable[ :].*"): "https://bugzilla.redhat.com/show_bug.cgi?id=1948087",
regexp.MustCompile(".*clusteroperator/kube-storage-version-migrator condition/Available status/False reason/KubeStorageVersionMigrator_Deploying[ :].*"): "https://bugzilla.redhat.com/show_bug.cgi?id=1948087",
regexp.MustCompile(".*clusteroperator/machine-config condition/Available status/False reason/Cluster not available[ :].*"): "https://bugzilla.redhat.com/show_bug.cgi?id=2051075",
regexp.MustCompile(".*clusteroperator/storage condition/Available status/False reason/AWSEBSCSIDriverOperatorCR_AWSEBSDriverControllerServiceController_Deploying .*"): "https://bugzilla.redhat.com/show_bug.cgi?id=2081557",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest reason/.*CSIDriverOperatorCR_.*DriverControllerServiceController_Deploying to catch all CSI driver operators. oVirt, IBM cloud, Alibaba, vSphere and OpenStack will have the same blips during upgrade.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and is this the right Bugzilla tracker for those blips?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I will flip it back to Assigned once the current fixes merge.

regexp.MustCompile(".*clusteroperator/kube-storage-version-migrator condition/Available status/False reason/KubeStorageVersionMigrator_Deploying[ :].*"): "https://bugzilla.redhat.com/show_bug.cgi?id=1948087",
regexp.MustCompile(".*clusteroperator/machine-config condition/Available status/False reason/Cluster not available[ :].*"): "https://bugzilla.redhat.com/show_bug.cgi?id=2051075",
regexp.MustCompile(".*clusteroperator/storage condition/Available status/False reason/AWSEBSCSIDriverOperatorCR_AWSEBSDriverControllerServiceController_Deploying .*"): "https://bugzilla.redhat.com/show_bug.cgi?id=2081557",
regexp.MustCompile(".*clusteroperator/storage condition/Available status/False reason/AWSEBSCSIDriverOperatorDeployment_Deploying[ :].*"): "https://bugzilla.redhat.com/show_bug.cgi?id=2081557",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dtto, reason/.*CSIDriverOperatorDeployment_Deploying

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right Bugzilla tracker for those blips?

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2023
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 6, 2023
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Oct 3, 2023

/remove-lifecycle stale
/reopen

@openshift-ci openshift-ci bot reopened this Oct 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

@wking: Reopened this PR.

In response to this:

/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2023
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2167): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (653): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@wking
Copy link
Member Author

wking commented Dec 1, 2023

/retest-required

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2174): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (653): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn IncompleteTests
Tests for this run (99) are below the historical average (1549): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2174): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (653): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@wking
Copy link
Member Author

wking commented Dec 1, 2023

openshift/cluster-storage-operator#426 might help.

/retest-required

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2205): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (662): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@wking
Copy link
Member Author

wking commented Dec 1, 2023

/retest-required

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2217): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (664): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 80b0ef7 and 1 for PR HEAD 0b4bb1d in total

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2249): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (655): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@wking
Copy link
Member Author

wking commented Dec 2, 2023

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2260): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (658): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

1 similar comment
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2260): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (658): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@wking
Copy link
Member Author

wking commented Dec 2, 2023

/retest-required

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2237): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (661): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5b587d9 and 0 for PR HEAD 0b4bb1d in total

@openshift-ci-robot
Copy link

/hold

Revision 0b4bb1d was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2023
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2247): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (660): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

1 similar comment
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2247): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (660): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@wking
Copy link
Member Author

wking commented Dec 3, 2023

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5b587d9 and 2 for PR HEAD 0b4bb1d in total

Copy link
Contributor

openshift-ci bot commented Dec 3, 2023

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd 054f30d link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-single-node-upgrade 054f30d link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-gcp-ovn-image-ecosystem 054f30d link true /test e2e-gcp-ovn-image-ecosystem
ci/prow/e2e-aws-ovn-single-node-serial 0b4bb1d link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-csi 0b4bb1d link false /test e2e-aws-csi
ci/prow/e2e-gcp-ovn-rt-upgrade 0b4bb1d link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node 0b4bb1d link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-upgrade 0b4bb1d link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade 0b4bb1d link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-agnostic-ovn-cmd 0b4bb1d link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-openstack-ovn 0b4bb1d link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-cgroupsv2 0b4bb1d link false /test e2e-aws-ovn-cgroupsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2230): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (661): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-serial IncompleteTests
Tests for this run (16) are below the historical average (728): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-fips IncompleteTests
Tests for this run (16) are below the historical average (1770): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

1 similar comment
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0b4bb1d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (17) are below the historical average (2230): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (15) are below the historical average (661): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-serial IncompleteTests
Tests for this run (16) are below the historical average (728): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-fips IncompleteTests
Tests for this run (16) are below the historical average (1770): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@wking
Copy link
Member Author

wking commented Dec 3, 2023

gmp-devel-1:6.1.2-10.el8.x86_64: Cannot download, all mirrors were already tried without success is unrelated to my pull, although searching doesn't turn up hits in other places. Maybe a temporary hiccup?

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit d75092b into openshift:master Dec 3, 2023
13 of 22 checks passed
@wking wking deleted the fatal-available-false branch December 3, 2023 21:12
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.15.0-202312040732.p0.gd75092b.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants