Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-5825: Adds GCP ClusterRole and ClusterRoleBinding #310

Merged
merged 1 commit into from Dec 19, 2023

Conversation

theobarberbany
Copy link
Contributor

@theobarberbany theobarberbany commented Dec 18, 2023

This change adds back the ClusterRole and ClusterRoleBinding removed in this PR OCPBUGS-5825.

This is because it is still required at present.

@theobarberbany theobarberbany force-pushed the tb/fix-sa-bug branch 2 times, most recently from 8d5306a to 13cde3e Compare December 18, 2023 14:19
This change adds back the ClusterRole and ClusterRoleBinding removed in
[OCPBUGS-5825](openshift/cluster-kube-controller-manager-operator#778).

This is because it is still required at present.
@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@theobarberbany theobarberbany changed the title Adds GCP ClusterRole and ClusterRoleBinding OCPBUGS-5825: Adds GCP ClusterRole and ClusterRoleBinding Dec 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 18, 2023
@openshift-ci-robot
Copy link

@theobarberbany: This pull request references Jira Issue OCPBUGS-5825, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change adds back the ClusterRole and ClusterRoleBinding removed in OCPBUGS-5825.

This is because it is still required at present.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 18, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@theobarberbany
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@theobarberbany: This pull request references Jira Issue OCPBUGS-5825, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theobarberbany
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 18, 2023
@openshift-ci-robot
Copy link

@theobarberbany: This pull request references Jira Issue OCPBUGS-5825, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 18, 2023
@openshift-ci openshift-ci bot requested a review from miyadav December 18, 2023 16:49
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8a71f3e and 2 for PR HEAD 048086a in total

@theobarberbany
Copy link
Contributor Author

/retest

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-ovn

I'm confident that this change isn't going to affect AWS, but, the change is blocking GCP CI from going green, so I think in this case it's desirable to override

Copy link
Contributor

openshift-ci bot commented Dec 19, 2023

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

I'm confident that this change isn't going to affect AWS, but, the change is blocking GCP CI from going green, so I think in this case it's desirable to override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 19, 2023

@theobarberbany: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 048086a link false /test e2e-openstack-ovn
ci/prow/e2e-alibaba-ovn 048086a link false /test e2e-alibaba-ovn
ci/prow/e2e-azure-ovn 048086a link false /test e2e-azure-ovn
ci/prow/e2e-gcp-ovn-ccm 048086a link false /test e2e-gcp-ovn-ccm
ci/prow/e2e-gcp-ovn-techpreview 048086a link false /test e2e-gcp-ovn-techpreview
ci/prow/e2e-vsphere-ovn 048086a link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d9a1ea3 into openshift:master Dec 19, 2023
10 of 16 checks passed
@openshift-ci-robot
Copy link

@theobarberbany: Jira Issue OCPBUGS-5825: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5825 has been moved to the MODIFIED state.

In response to this:

This change adds back the ClusterRole and ClusterRoleBinding removed in this PR OCPBUGS-5825.

This is because it is still required at present.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202312191432.p0.gd9a1ea3.assembly.stream for distgit ose-cluster-cloud-controller-manager-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants