New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-5825: Adds GCP ClusterRole and ClusterRoleBinding #310
OCPBUGS-5825: Adds GCP ClusterRole and ClusterRoleBinding #310
Conversation
7883b25
to
10e3708
Compare
pkg/cloud/gcp/assets/gcp-cloud-controller-manager-clusterrolebinding.yaml
Outdated
Show resolved
Hide resolved
8d5306a
to
13cde3e
Compare
This change adds back the ClusterRole and ClusterRoleBinding removed in [OCPBUGS-5825](openshift/cluster-kube-controller-manager-operator#778). This is because it is still required at present.
13cde3e
to
048086a
Compare
/approve |
@theobarberbany: This pull request references Jira Issue OCPBUGS-5825, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@theobarberbany: This pull request references Jira Issue OCPBUGS-5825, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@theobarberbany: This pull request references Jira Issue OCPBUGS-5825, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/override ci/prow/e2e-aws-ovn I'm confident that this change isn't going to affect AWS, but, the change is blocking GCP CI from going green, so I think in this case it's desirable to override |
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@theobarberbany: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
d9a1ea3
into
openshift:master
@theobarberbany: Jira Issue OCPBUGS-5825: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-5825 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202312191432.p0.gd9a1ea3.assembly.stream for distgit ose-cluster-cloud-controller-manager-operator. |
This change adds back the ClusterRole and ClusterRoleBinding removed in this PR OCPBUGS-5825.
This is because it is still required at present.