New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-5825: Removes legacy cloud-provider resources #778
OCPBUGS-5825: Removes legacy cloud-provider resources #778
Conversation
@theobarberbany: This pull request references Jira Issue OCPBUGS-5825, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Code change looks ok, should verify that both install and upgrade jobs do not have these resources in their must-gathers once the CI runs complete |
/jira refresh |
@theobarberbany: This pull request references Jira Issue OCPBUGS-5825, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
215a803
to
d7d8fd6
Compare
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theobarberbany thx for the PR, but there are a few changes required
pkg/operator/starter.go
Outdated
[]string{ | ||
"assets/kube-controller-manager/gce/cloud-provider-role.yaml", | ||
"assets/kube-controller-manager/gce/cloud-provider-binding.yaml", | ||
"assets/kube-controller-manager/sa.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sa should be kept. I think the sa for cloud-provider comes from kube
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this one. Thanks for noticing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @atiratree :)
I think the sa for cloud-provider comes from kube
Does this mean there's a SA somewhere else I need to remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the SA should be created automatically when the controller runs
so, no action required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! :)
).WithConditionalResources( | ||
bindata.Asset, | ||
[]string{ | ||
"assets/kube-controller-manager/gce/cloud-provider-role.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove these two files from the main list above
return false | ||
}, | ||
func() bool { | ||
// The resources above are required for the 4.14 -> 4.15 upgrade path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you planning to backport this to 4.15 branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this would break 4.14 to 4.15 upgrades, that's why we are doing this now. The file needs to be removed only once the upgrade to 4.15 is complete, it cannot be removed mid update as that could cause KCM to fall over and halt the upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, 4.15 is not released yet, so I think it could still work if we do it before the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ if the RBAC is not used in the 4.14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been working on the basis that RBAC is used in 4.14, that's why we are removing now, but I will double check when we stopped using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, confirmed, RBAC is used in 4.14, not used in 4.15, so I want to remove only from 4.16 to avoid breaking upgrades
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this. Ok let's remove this in 4.16 then.
/lgtm cancel |
This change removes the cloud-provider ClusterRole, ClusterRoleBinding and ServiceAccount that are no longer required from 4.16
d7d8fd6
to
2a7520b
Compare
@theobarberbany: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I'm good with this if @atiratree is, but note, do not want to backport to avoid potential breaking of upgrades |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, ingvagabund, theobarberbany The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b033b8e
into
openshift:master
@theobarberbany: Jira Issue OCPBUGS-5825: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-5825 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-kube-controller-manager-operator-container-v4.16.0-202312142332.p0.gb033b8e.assembly.stream for distgit ose-cluster-kube-controller-manager-operator. |
This change adds back the ClusterRole and ClusterRoleBinding removed in [OCPBUGS-5825](openshift/cluster-kube-controller-manager-operator#778). This is because it is still required at present.
This change adds back the ClusterRole and ClusterRoleBinding removed in [OCPBUGS-5825](openshift/cluster-kube-controller-manager-operator#778). This is because it is still required at present.
This change adds back the ClusterRole and ClusterRoleBinding removed in [OCPBUGS-5825](openshift/cluster-kube-controller-manager-operator#778). This is because it is still required at present.
This change adds back the ClusterRole and ClusterRoleBinding removed in [OCPBUGS-5825](openshift/cluster-kube-controller-manager-operator#778). This is because it is still required at present.
This change adds back the ClusterRole and ClusterRoleBinding removed in [OCPBUGS-5825](openshift/cluster-kube-controller-manager-operator#778). This is because it is still required at present.
This change adds back the ClusterRole and ClusterRoleBinding removed in [OCPBUGS-5825](openshift/cluster-kube-controller-manager-operator#778). This is because it is still required at present.
This change removes the cloud-provider ClusterRole, ClusterRoleBinding and ServiceAccount that are no longer required from 4.16