[release-4.9] Bug 2015306: bump api #224

EmilyM1 · 2021-11-16T01:24:28Z

This is to bump the api for backporting atomic-type-bug:
openshift/api#1036
For the changes made in bug 1992592 cluster-config needed an api bump that was done here for 4.10 which is this PR-
#219.
This PR is the corresponding bump for 4.9

If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
- verified
- does not apply
The bug has significant impact either through severity, reduction in supportability, or number of users affected.
- verified
- does not apply
For branches that are in the Maintenance lifecycle phase:
- The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
- The bug is a security related bug
- Branch not in maintenance mode yet (current release + previous release for 90 days after current GA; everything older is in maintenance)
The severity field of the bug must be set to accurately reflect criticality.
- verified
The PR was created with the cherry-pick bot OR the PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
- verified

openshift-ci · 2021-11-16T01:24:30Z

@EmilyM1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

bump api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stlaz · 2021-11-16T08:37:41Z

/hold
the bump attempts to bring master@o/api to release 4.8

EmilyM1 · 2021-11-16T17:18:03Z

closing while I get the status on 4.9

openshift-ci · 2021-11-16T17:20:03Z

@EmilyM1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

bump api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2021-11-23T07:17:02Z

go.mod

@@ -7,7 +7,7 @@ require (
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
 	github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32 // indirect
 	github.com/go-bindata/go-bindata v3.1.2+incompatible
-	github.com/openshift/api v0.0.0-20210817132244-67c28690af52
+	github.com/openshift/api v0.0.0-20211014164657-4436dc8be01e


if I am not mistaken, 4436dc8be01e is not the release-4.9 branch.

sttts · 2021-11-23T07:18:29Z

Can you squash? The first commit looks wrong, but the later fixes it.

EmilyM1 · 2021-11-23T20:21:21Z

/retest

EmilyM1 · 2021-11-24T18:29:38Z

/retest

EmilyM1 · 2021-11-29T23:24:48Z

/test e2e-upgrade

s-urbaniak · 2021-11-30T06:32:52Z

vendor/github.com/openshift/api/go.mod

-	k8s.io/code-generator v0.22.0-rc.0
+	k8s.io/api v0.22.1
+	k8s.io/apimachinery v0.22.1
+	k8s.io/code-generator v0.22.1


why is the bump to 0.22.1 necessary?

s-urbaniak · 2021-11-30T06:33:48Z

@EmilyM1 please reference the underlying bug in the PR description and add a title.

openshift-ci · 2021-12-01T01:29:14Z

@EmilyM1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

bump api for 2015306 - list-type missing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-12-01T01:31:49Z

@EmilyM1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

bump api for 2015306 - list-type missing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilyM1 · 2021-12-01T01:32:36Z

@sur check the new description and the #219 for why this is needed on the backport

openshift-ci · 2021-12-01T01:33:03Z

@EmilyM1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

bump api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-12-01T01:38:15Z

@EmilyM1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

bump api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-12-02T18:48:19Z

@EmilyM1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug 2015306 bump api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2021-12-07T07:56:03Z

go.mod

-	k8s.io/api v0.22.0
-	k8s.io/apimachinery v0.22.0
+	k8s.io/api v0.22.1
+	k8s.io/apimachinery v0.22.1


can we bump all of the kube libs to the same version?

Sure, I'll try v0.22.1

EmilyM1 · 2021-12-08T19:45:41Z

/test e2e-upgrade

s-urbaniak · 2021-12-14T08:54:26Z

please squash into one commit, else lgtm

openshift-ci · 2021-12-14T20:24:44Z

@EmilyM1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2021-12-14T20:46:14Z

@EmilyM1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug 2015306 bump api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s-urbaniak · 2021-12-22T07:26:10Z

/lgtm

s-urbaniak · 2021-12-22T07:26:56Z

/label backport-risk-assessed

soltysh

/approve
/hold cancel

openshift-ci · 2021-12-22T10:03:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilyM1, s-urbaniak, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wangke19 · 2021-12-22T14:53:44Z

/bugzilla refresh

openshift-ci · 2021-12-22T14:53:46Z

@wangke19: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wangke19 · 2021-12-22T14:59:13Z

/retitle [release-4.9] Bug: 2015306 bump api

openshift-ci · 2021-12-22T14:59:15Z

@EmilyM1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug: 2015306 bump api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wangke19 · 2021-12-22T14:59:27Z

/bugzilla refresh

openshift-ci · 2021-12-22T14:59:28Z

@wangke19: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wangke19 · 2021-12-22T15:00:26Z

/retitle [release-4.9] Bug 2015306: bump api

openshift-ci · 2021-12-22T15:00:36Z

@EmilyM1: This pull request references Bugzilla bug 2015306, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1992592 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1992592 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ytripath@redhat.com), skipping review request.

In response to this:

[release-4.9] Bug 2015306: bump api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wangke19 · 2021-12-22T15:00:38Z

/bugzilla refresh

openshift-ci · 2021-12-22T15:00:42Z

@wangke19: This pull request references Bugzilla bug 2015306, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1992592 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1992592 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ytripath@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wangke19 · 2021-12-22T15:00:55Z

/label cherry-pick-approved

openshift-ci · 2021-12-22T15:02:17Z

@EmilyM1: All pull requests linked via external trackers have merged:

Bugzilla bug 2015306 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2015306: bump api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from deads2k and sttts November 16, 2021 01:26

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2021

EmilyM1 closed this Nov 16, 2021

EmilyM1 reopened this Nov 16, 2021

sttts reviewed Nov 23, 2021

View reviewed changes

EmilyM1 force-pushed the bump-version-type-bug branch from feec866 to b01ef0e Compare November 23, 2021 18:36

s-urbaniak reviewed Nov 30, 2021

View reviewed changes

EmilyM1 changed the title ~~bump api~~ bump api for 2015306 - list-type missing Dec 1, 2021

EmilyM1 changed the title ~~bump api for 2015306 - list-type missing~~ bump api Dec 1, 2021

EmilyM1 changed the title ~~bump api~~ [release-4.9] Bug 2015306 bump api Dec 2, 2021

sttts reviewed Dec 7, 2021

View reviewed changes

bump-api 4.9

eb025d8

EmilyM1 force-pushed the bump-version-type-bug branch from ecf60dd to eb025d8 Compare December 14, 2021 18:15

openshift-ci bot assigned s-urbaniak Dec 22, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 22, 2021

soltysh approved these changes Dec 22, 2021

View reviewed changes

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2021

openshift-ci bot changed the title ~~[release-4.9] Bug 2015306 bump api~~ [release-4.9] Bug: 2015306 bump api Dec 22, 2021

openshift-ci bot changed the title ~~[release-4.9] Bug: 2015306 bump api~~ [release-4.9] Bug 2015306: bump api Dec 22, 2021

openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Dec 22, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 22, 2021

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 22, 2021

openshift-merge-robot merged commit 184a513 into openshift:release-4.9 Dec 22, 2021

[release-4.9] Bug 2015306: bump api #224

[release-4.9] Bug 2015306: bump api #224

Conversation

EmilyM1 commented Nov 16, 2021 • edited

openshift-ci bot commented Nov 16, 2021

stlaz commented Nov 16, 2021

EmilyM1 commented Nov 16, 2021

openshift-ci bot commented Nov 16, 2021

sttts Nov 23, 2021

Choose a reason for hiding this comment

sttts commented Nov 23, 2021

EmilyM1 commented Nov 23, 2021

EmilyM1 commented Nov 24, 2021

EmilyM1 commented Nov 29, 2021

s-urbaniak Nov 30, 2021

Choose a reason for hiding this comment

s-urbaniak commented Nov 30, 2021

openshift-ci bot commented Dec 1, 2021

openshift-ci bot commented Dec 1, 2021

EmilyM1 commented Dec 1, 2021

openshift-ci bot commented Dec 1, 2021

openshift-ci bot commented Dec 1, 2021

openshift-ci bot commented Dec 2, 2021

sttts Dec 7, 2021

Choose a reason for hiding this comment

EmilyM1 Dec 7, 2021

Choose a reason for hiding this comment

EmilyM1 commented Dec 8, 2021

s-urbaniak commented Dec 14, 2021

openshift-ci bot commented Dec 14, 2021

openshift-ci bot commented Dec 14, 2021

s-urbaniak commented Dec 22, 2021

s-urbaniak commented Dec 22, 2021

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Dec 22, 2021

wangke19 commented Dec 22, 2021

openshift-ci bot commented Dec 22, 2021

wangke19 commented Dec 22, 2021

openshift-ci bot commented Dec 22, 2021

wangke19 commented Dec 22, 2021

openshift-ci bot commented Dec 22, 2021

wangke19 commented Dec 22, 2021

openshift-ci bot commented Dec 22, 2021

wangke19 commented Dec 22, 2021

openshift-ci bot commented Dec 22, 2021

wangke19 commented Dec 22, 2021

openshift-ci bot commented Dec 22, 2021

EmilyM1 commented Nov 16, 2021 •

edited