OCPBUGS-15877: go upgradeable=false when latencysensitive is used and not corrected

[deads2k]

There are relatively few clusters even potentially impacted and we further limit that by automatically setting the equivalent featureset of "" in #324 . This blocks upgrades if the value is not "".

[JoelSpeed]

Changes look good, but you'll need to add a new exception to the "should start all core operators test" else it will break all TPNU jobs if we merge this

{  fail [github.com/openshift/origin/test/extended/operators/operators.go:114]: Some cluster operators are not ready: config-operator (Upgradeable=False FeatureGates_RestrictedFeatureGates_TechPreviewNoUpgrade: FeatureGatesUpgradeable: "TechPreviewNoUpgrade" does not allow updates)
Ginkgo exit error 1: exit with code 1}

[dinhxuanvu]

Changes look good, but you'll need to add a new exception to the "should start all core operators test" else it will break all TPNU jobs if we merge this

{  fail [github.com/openshift/origin/test/extended/operators/operators.go:114]: Some cluster operators are not ready: config-operator (Upgradeable=False FeatureGates_RestrictedFeatureGates_TechPreviewNoUpgrade: FeatureGatesUpgradeable: "TechPreviewNoUpgrade" does not allow updates)
Ginkgo exit error 1: exit with code 1}

It looks like the test meant to ignore certain conditions but the current check doesn't match with what David introduced in this PR. The test can be changed to address this problem.

[deads2k]

/retest

[openshift-ci-robot]

@deads2k: This pull request references Jira Issue OCPBUGS-15877, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

There are relatively few clusters even potentially impacted and we further limit that by automatically setting the equivalent featureset of "" in #324 . This blocks upgrades if the value is not "".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[deads2k]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed,deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2618cff and 2 for PR HEAD be70b5a in total

[deads2k]

/override ci/prow/e2e-aws-ovn

[openshift-ci]

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@deads2k: Jira Issue OCPBUGS-15877: All pull requests linked via external trackers have merged:

• openshift/cluster-config-operator#325

Jira Issue OCPBUGS-15877 has been moved to the MODIFIED state.

In response to this:

There are relatively few clusters even potentially impacted and we further limit that by automatically setting the equivalent featureset of "" in #324 . This blocks upgrades if the value is not "".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@deads2k: #325 failed to apply on top of branch "release-4.13":

Applying: go upgradeable=false when latencysensitive is used and not corrected
Using index info to reconstruct a base tree...
M	pkg/operator/starter.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/starter.go
CONFLICT (content): Merge conflict in pkg/operator/starter.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 go upgradeable=false when latencysensitive is used and not corrected
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.