New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.14] OCPBUGS-20439: Remove Build CRD #363
[release-4.14] OCPBUGS-20439: Remove Build CRD #363
Conversation
@adambkaplan: This pull request references Jira Issue OCPBUGS-20164, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adambkaplan: This pull request references Jira Issue OCPBUGS-20439, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@bparees: This pull request references Jira Issue OCPBUGS-20439, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
manually labeling this as valid-bug, we're going to merge out of order (merge to 4.14 first, then follow with 4.15) due to time constraints for getting this into 4.14.0. There is ample time to avoid any regression concerns. |
/hold needs to be updated w/ a proper bump from openshift/api once openshift/api#1617 lands |
/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-aws-ovn-no-capabilities |
@wking: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/32902a40-68a7-11ee-95a8-cce051792342-0 |
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/openshift-cluster-config-operator-363-ci-4.14-e2e-aws-ovn-no-capabilities/1712294465357484032/artifacts/e2e-aws-ovn-no-capabilities/gather-must-gather/artifacts/must-gather.tar | tar tvz | grep builds.config
-rw------- 1006330000/root 26768 2023-10-11 21:03 registry-build01-ci-openshift-org-ci-op-0v5f3hgv-stable-sha256-9d4dcf33eebdeb01573a70cc4aa0f7f9e492a5f2d5cfdfd410d5bd00766302f8/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/builds.config.openshift.io.yaml
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/openshift-cluster-config-operator-363-ci-4.14-e2e-aws-ovn-no-capabilities/1712294465357484032/artifacts/e2e-aws-ovn-no-capabilities/gather-must-gather/artifacts/must-gather.tar | tar xOz registry-build01-ci-openshift-org-ci-op-0v5f3hgv-stable-sha256-9d4dcf33eebdeb01573a70cc4aa0f7f9e492a5f2d5cfdfd410d5bd00766302f8/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/builds.config.openshift.io.yaml | yaml2json | jq -r '.metadata.managedFields[] | select(.subresource != "status") | .time + " " + .operation + " " + .manager'
2023-10-12T02:48:10Z Update cluster-bootstrap So this is still getting into the cluster at bootstrap time, via the config |
Rename Build CRD yaml so that it is not included in cluster-config-operator's set of manifests.
Remove Build CRD empty resource so it doesn't get included in manifests.
d1b0617
to
3f064ab
Compare
@adambkaplan: This pull request references Jira Issue OCPBUGS-20439, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. Retaining the jira/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: adambkaplan, bparees The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@adambkaplan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@adambkaplan: Jira Issue OCPBUGS-20439: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-20439 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.14.0-0.nightly-2023-10-13-032002 |
Fix included in accepted release 4.14.0-0.nightly-2023-10-13-073537 |
Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657 |
Rename Build CRD yaml so that it is not included in cluster-config-operator's set of manifests. Build CRD will be owned and managed by openshift-controller-manager-operator moving forward.
Manual cherry-pick of #360, may require openshift/cluster-openshift-controller-manager-operator#307 to land first.