Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-20439: Rename manifest for Build CRD #1620

Merged

Conversation

adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Oct 12, 2023

Marking the Build CRD as associated with the "Build" capability and "owned" by openshift-controller-manager-operator. This means that its CRD manifest will be included in the ocm-o image, with the right annotations to mark it as part of the "Build" capability.

This picks in updates from #1618 that were added after #1617 was merged.

Marking the Build CRD as associated with the "Build" capability
and "owned" by openshift-controller-manager-operator. This means
that its CRD manifest will be included in the ocm-o image, with
the right annotations to mark it as part of the "Build" capability.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023
@openshift-ci-robot
Copy link

@adambkaplan: This pull request references Jira Issue OCPBUGS-20164, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.15.0" instead
  • expected Jira Issue OCPBUGS-20164 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Marking the Build CRD as associated with the "Build" capability and "owned" by openshift-controller-manager-operator. This means that its CRD manifest will be included in the ocm-o image, with the right annotations to mark it as part of the "Build" capability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

Hello @adambkaplan! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2023
@adambkaplan adambkaplan changed the title OCPBUGS-20164: Rename manifest for Build CRD OCPBUGS-20439: Rename manifest for Build CRD Oct 12, 2023
@openshift-ci-robot
Copy link

@adambkaplan: This pull request references Jira Issue OCPBUGS-20439, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20164 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Marking the Build CRD as associated with the "Build" capability and "owned" by openshift-controller-manager-operator. This means that its CRD manifest will be included in the ocm-o image, with the right annotations to mark it as part of the "Build" capability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from eparis and knobunc October 12, 2023 18:37
@bparees bparees added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023
@bparees
Copy link
Contributor

bparees commented Oct 12, 2023

/approve
/lgtm

@bparees
Copy link
Contributor

bparees commented Oct 12, 2023

/override ci/prow/verify-crd-schema

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@bparees: Overrode contexts on behalf of bparees: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@adambkaplan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema b00fc53 link true /test verify-crd-schema

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adambkaplan adambkaplan changed the title OCPBUGS-20439: Rename manifest for Build CRD [release-4.14] OCPBUGS-20439: Rename manifest for Build CRD Oct 12, 2023
@bparees bparees added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 12, 2023
@openshift-ci openshift-ci bot merged commit 7b36cb3 into openshift:release-4.14 Oct 12, 2023
8 checks passed
@openshift-ci-robot
Copy link

@adambkaplan: Jira Issue OCPBUGS-20439: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-20439 has not been moved to the MODIFIED state.

In response to this:

Marking the Build CRD as associated with the "Build" capability and "owned" by openshift-controller-manager-operator. This means that its CRD manifest will be included in the ocm-o image, with the right annotations to mark it as part of the "Build" capability.

This picks in updates from #1618 that were added after #1617 was merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-10-13-032002

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-10-13-073537

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants