Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1805: Set SecurityContext for HyperShift #197

Merged
merged 1 commit into from Mar 29, 2024
Merged

STOR-1805: Set SecurityContext for HyperShift #197

merged 1 commit into from Mar 29, 2024

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Mar 6, 2024 •
edited

Set's the RunAsNonRoot to false and the RunAsUser to 1001 if the management cluster HyperShift is running on does not support SCC. This is needed for running HyperShift on non-OpenShift management cluster's such as AKS as part of OCPSTRAT-460.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2024 •
edited by openshift-ci bot

@bryan-cox: This pull request references STOR-1805 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2024 •
edited by openshift-ci bot

@bryan-cox: This pull request references STOR-1805 which is a valid jira issue.

In response to this:

Set's the RunAsNonRoot to false and the RunAsUser to 1001 if the management cluster HyperShift is running on does not support SCC. This is needed for running HyperShift on non-OpenShift management cluster's such as AKS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox marked this pull request as ready for review March 6, 2024 21:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana March 6, 2024 21:16
jsafrane
jsafrane reviewed Mar 7, 2024
View reviewed changes
pkg/operator/starter.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 7, 2024 •
edited by openshift-ci bot

@bryan-cox: This pull request references STOR-1805 which is a valid jira issue.

In response to this:

Set's the RunAsNonRoot to false and the RunAsUser to 1001 if the management cluster HyperShift is running on does not support SCC. This is needed for running HyperShift on non-OpenShift management cluster's such as AKS as part of OCPSTRAT-460.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/test e2e-gcp-csi

jsafrane
jsafrane reviewed Mar 28, 2024
View reviewed changes
pkg/operator/starter.go Outdated Show resolved Hide resolved
pkg/operator/starter.go Outdated Show resolved Hide resolved
@jsafrane
Copy link
Contributor

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Mar 28, 2024
@jsafrane
Copy link
Contributor

/approve
Just waiting for CI...

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@bryan-cox
Copy link
Member Author

/test images

@bryan-cox
Copy link
Member Author

/test e2e-gcp-csi

@bryan-cox bryan-cox mentioned this pull request Mar 28, 2024
Merged
4 tasks
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-conformance 9440696 link false /test e2e-hypershift-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@duanwei33
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 29, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 29, 2024 •
edited by openshift-ci bot

@bryan-cox: This pull request references STOR-1805 which is a valid jira issue.

In response to this:

Set's the RunAsNonRoot to false and the RunAsUser to 1001 if the management cluster HyperShift is running on does not support SCC. This is needed for running HyperShift on non-OpenShift management cluster's such as AKS as part of OCPSTRAT-460.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 8b1d35f into openshift:master Mar 29, 2024
9 of 10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-csi-snapshot-controller-operator-container-v4.16.0-202403290911.p0.g8b1d35f.assembly.stream.el9 for distgit ose-cluster-csi-snapshot-controller-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@dobsonj dobsonj Awaiting requested review from dobsonj

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bryan-cox @openshift-ci-robot @jsafrane @bertinatto @duanwei33 @openshift-bot