-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1807615: Add extra check for v1alpha CRD #40
Bug 1807615: Add extra check for v1alpha CRD #40
Conversation
The operator should print a human friendly message when v1alpha1 CRDs are detected. Such cluster can't support OCP v1beta1 version of snapshots and users should know why.
@jsafrane: This pull request references Bugzilla bug 1807615, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
reactors: testReactors{ | ||
crds: addCRDEstablishedRector, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a case with v1beta1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1beta1 is used in most previous cases, e.g. https://github.com/openshift/cluster-csi-snapshot-controller-operator/blob/b635111bb788b883653f8bce0d37c28457b10bf1/pkg/operator/operator_test.go#L400-L399
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@jsafrane: All pull requests linked via external trackers have merged: openshift/cluster-csi-snapshot-controller-operator#40. Bugzilla bug 1807615 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.5 |
@jsafrane: new pull request created: #41 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The operator should print a human friendly message when v1alpha1 CRDs are detected. Such cluster can't support OCP v1beta1 version of snapshots and users should know why.
Example of such error:
cc @openshift/storage