Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1807615: Add extra check for v1alpha CRD #40

Merged
merged 1 commit into from Jun 9, 2020
Merged

Bug 1807615: Add extra check for v1alpha CRD #40

merged 1 commit into from Jun 9, 2020

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Jun 8, 2020

The operator should print a human friendly message when v1alpha1 CRDs are detected. Such cluster can't support OCP v1beta1 version of snapshots and users should know why.

Example of such error:

  status:
    conditions:
    - lastTransitionTime: "2020-06-08T13:14:49Z"
      status: "False"
      type: ManagementStateDegraded
    - lastTransitionTime: "2020-06-08T13:14:50Z"
      message: 'failed to sync CRDs: cluster-csi-snapshot-controller-operator does
        not support v1alpha1 version of snapshot CRDs volumesnapshots.snapshot.storage.k8s.io,
        volumesnapshotcontents.snapshot.storage.k8s.io, volumesnapshotclasses.snapshot.storage.k8s.io
        installed by user or 3rd party controller'
      reason: AlphaCRDsExist
      status: "True"
      type: Degraded
    readyReplicas: 0

cc @openshift/storage

@jsafrane
Add extra check for v1alpha CRD
866fc2c 
The operator should print a human friendly message when v1alpha1 CRDs are
detected. Such cluster can't support OCP v1beta1 version of snapshots and
users should know why.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 8, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Bugzilla bug 1807615, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1807615: Add extra check for v1alpha CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2020
bertinatto
bertinatto reviewed Jun 9, 2020
View reviewed changes
pkg/operator/operator_test.go
reactors: testReactors{
crds: addCRDEstablishedRector,
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a case with v1beta1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1beta1 is used in most previous cases, e.g. https://github.com/openshift/cluster-csi-snapshot-controller-operator/blob/b635111bb788b883653f8bce0d37c28457b10bf1/pkg/operator/operator_test.go#L400-L399

bertinatto
bertinatto reviewed Jun 9, 2020
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3942cdc into openshift:master Jun 9, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: All pull requests linked via external trackers have merged: openshift/cluster-csi-snapshot-controller-operator#40. Bugzilla bug 1807615 has been moved to the MODIFIED state.

In response to this:

Bug 1807615: Add extra check for v1alpha CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor Author

jsafrane commented Jun 9, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 9, 2020
Merged
@openshift-cherrypick-robot
Copy link

@jsafrane: new pull request created: #41

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsafrane @openshift-ci-robot @openshift-cherrypick-robot @bertinatto @openshift-merge-robot