Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add management workload annotations #84

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add management workload annotations #84

merged 1 commit into from
Apr 29, 2021

Conversation

cynepco3hahue
Copy link
Contributor

In support of the workload partitioning feature
(openshift/enhancements#703), we need to add
annotations to all management pods and namespaces so they can be
properly identified and assigned to segregated management cores on
clusters configured to do so.

Signed-off-by: Artyom Lukianov alukiano@redhat.com

bertinatto
bertinatto reviewed Apr 8, 2021
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the bindata with make update.

@cynepco3hahue cynepco3hahue force-pushed the management-workload-annotations branch from 9fd78f4 to bd368f2 Compare April 8, 2021 08:43
@cynepco3hahue
Copy link
Contributor Author

Please update the bindata with make update.

Thanks. Done.

@cynepco3hahue
Copy link
Contributor Author

/retest

@mrunalp mrunalp added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 15, 2021
@cynepco3hahue
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2021
Add management workload annotations
a67f7f2 
In support of the workload partitioning feature
(openshift/enhancements#703), we need to add
annotations to all management pods and namespaces so they can be
properly identified and assigned to segregated management cores on
clusters configured to do so.

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@cynepco3hahue cynepco3hahue force-pushed the management-workload-annotations branch from bd368f2 to a67f7f2 Compare April 20, 2021 11:38
@lack
Copy link

lack commented Apr 20, 2021

/retest

1 similar comment
@lack
Copy link

lack commented Apr 20, 2021

/retest

@cynepco3hahue
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2021
@lack
Copy link

lack commented Apr 27, 2021

@bertinatto : This is ready for review again

@cynepco3hahue
Copy link
Contributor Author

/assign @bertinatto

bertinatto
bertinatto reviewed Apr 28, 2021
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bertinatto
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, cynepco3hahue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link

lack commented Apr 28, 2021

/retest

2 similar comments
@lack
Copy link

lack commented Apr 28, 2021

/retest

@lack
Copy link

lack commented Apr 29, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit f5c228f into openshift:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cynepco3hahue @lack @bertinatto @openshift-ci-robot @openshift-bot @mrunalp @openshift-merge-robot