Apply changes to service resource #159
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@ironcladlou: This pull request references Bugzilla bug 1805177, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
cc @Miciah |
openshift-ci-robot
added
the
approved
ironcladlou
force-pushed
the
apply-topology-keys
branch
from
3d896e3
to
126a8ba
Compare
ironcladlou
changed the title
|
I still need to do e2e testing of this. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
ironcladlou
changed the title
openshift-ci-robot
removed
the
bugzilla/valid-bug
|
@ironcladlou: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel @Miciah want to go ahead and merge this? |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/hold Wait for #159 and then rebase |
openshift-ci-robot
added
the
do-not-merge/hold
|
Does |
|
It doesn't get persisted — you're right, if we want to keep the general diff/apply logic I should remove serviceTopology entirely from the PR for now. |
ironcladlou
force-pushed
the
apply-topology-keys
branch
2 times, most recently
from
c2dd802
to
a9d8d33
Compare
|
/hold cancel @Miciah I rebased and updated the goal of this PR. PTAL. |
openshift-ci-robot
removed
the
do-not-merge/hold
| expect: true, | ||
| }, | ||
| { | ||
| description: "if .spec.publishNotReadyAddresses changes", |
There was a problem hiding this comment.
Maybe add a test for field Spec.ClusterIP as we call that out explicitly in serviceChanged()?
// Preserve fields that the API, other controllers, or user may have
// modified.
updated.Spec.ClusterIP = current.Spec.ClusterIP
The feature gate to support this isn't enabled yet.
Add support for applying changes to the service resource. Since the service topology feature gate isn't yet enabled, and add TODOs to re-introduce support when the gate is finally enabled.
ironcladlou
force-pushed
the
apply-topology-keys
branch
from
a9d8d33
to
915c08f
Compare
Done |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, ironcladlou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add support for applying changes to the service resource. Roll back 8ae4b02
since service topology feature gate isn't yet enabled, and add TODOs to
re-introduce support when the gate is finally enabled.
Part of, but not a complete fix for https://bugzilla.redhat.com/show_bug.cgi?id=1805177 because the service topology feature gate isn't enabled. Without that gate, service.spec.toplogyKey won't be persisted.