Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer node-local endpoints #190

Closed
wants to merge 1 commit into from

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Aug 22, 2020

Configure the cluster DNS service to send traffic to, in descending order of preference, a node-local, zone-local, region-local, or any available endpoint.

Reprise of #156, which was commented out in #159.

  • assets/dns/service.yaml: Specify topologyKeys.
  • pkg/manifests/bindata.go: Regenerate.

Configure the cluster DNS service to send traffic to, in descending order
of preference, a node-local, zone-local, region-local, or any available
endpoint.

Reprise of commit 8ae4b02, which was
commented out in commit a4213fa.

This commit fixes bug 1805177.

https://bugzilla.redhat.com/show_bug.cgi?id=1805177

* assets/dns/service.yaml: Specify topologyKeys.
* pkg/manifests/bindata.go: Regenerate.
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2020
@Miciah
Copy link
Contributor Author

Miciah commented Aug 22, 2020

The job timed out, and no artifacts were collected.
/test e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@Miciah: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 32a541a link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Miciah
Copy link
Contributor Author

Miciah commented Sep 8, 2020

@openshift-ci-robot
Copy link
Contributor

@Miciah: Closed this PR.

In response to this:

Service topology is still disabled: https://github.com/openshift/kubernetes/blob/release-4.6/pkg/features/kube_features.go#L729

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants