Bug 1837540: Use restore pod yaml from the backup when restoring

[retroflexer]

Currently when we restore a cluster from backup, we use restore-pod.yaml from the currently installed image. This is problematic especially when switching across releases (minor or micro release versions).

[openshift-ci-robot]

@retroflexer: This pull request references Bugzilla bug 1837540, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1837540: Use restore pod yaml from the backup when restoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

@retroflexer can we remove RESTORE_ETCD_POD_YAML, I don't think we need that anymore right?

cluster-etcd-operator/bindata/etcd/etcd-common-tools

Line 8 in 68d208b

RESTORE_ETCD_POD_YAML="${CONFIG_FILE_DIR}/static-pod-resources/etcd-certs/configmaps/restore-etcd-pod/pod.yaml"

[retroflexer]

/test e2e-upgrade

[hexfusion]

/hold

I would like to understand disruptive failure;
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/436/pull-ci-openshift-cluster-etcd-operator-master-e2e-disruptive/1303731232332320768

[sig-etcd][Feature:DisasterRecovery][Disruptive] [Feature:EtcdRecovery] Cluster should restore itself after quorum loss [Serial] [Suite:openshift] expand_less	11m54s
fail [github.com/openshift/origin/test/extended/dr/common.go:299]: Unexpected error:
    <*errors.errorString | 0xc0009ed4c0>: {
        s: "failed running \"sudo -i /bin/bash -cx '/usr/local/bin/cluster-restore.sh /home/core/backup'\": <nil> (exit code 1, stderr + /usr/local/bin/cluster-restore.sh /home/core/backup\n)",
    }
    failed running "sudo -i /bin/bash -cx '/usr/local/bin/cluster-restore.sh /home/core/backup'": <nil> (exit code 1, stderr + /usr/local/bin/cluster-restore.sh /home/core/backup
    )
occurred

[retroflexer]

/retest

[retroflexer]

@retroflexer can we remove RESTORE_ETCD_POD_YAML, I don't think we need that anymore right?

cluster-etcd-operator/bindata/etcd/etcd-common-tools

Line 8 in 68d208b

RESTORE_ETCD_POD_YAML="${CONFIG_FILE_DIR}/static-pod-resources/etcd-certs/configmaps/restore-etcd-pod/pod.yaml"

[openshift-ci-robot]

@retroflexer: This pull request references Bugzilla bug 1837540. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1837540: Use restore pod yaml from the backup when restoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@retroflexer: This pull request references Bugzilla bug 1837540, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1837540: Use restore pod yaml from the backup when restoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@retroflexer: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-disruptive	8b146ce	link	/test e2e-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hexfusion]

Based on manual testing results from @retroflexer this is working as expected.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hexfusion]

/hold cancel

[openshift-ci-robot]

@retroflexer: All pull requests linked via external trackers have merged:

• openshift/cluster-etcd-operator#436

Bugzilla bug 1837540 has been moved to the MODIFIED state.

In response to this:

Bug 1837540: Use restore pod yaml from the backup when restoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[retroflexer]

/cherry-pick 4.5

[openshift-cherrypick-robot]

@retroflexer: cannot checkout 4.5: error checking out 4.5: exit status 1. output: error: pathspec '4.5' did not match any file(s) known to git

In response to this:

/cherry-pick 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[retroflexer]

/cherry-pick release-4.5

[openshift-cherrypick-robot]

@retroflexer: new pull request created: #439

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[retroflexer]

/cherry-pick release-4.4

[openshift-cherrypick-robot]

@retroflexer: new pull request created: #441

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.