[release-4.5] Bug 1877930: Use restore pod yaml from the backup when restoring #442

retroflexer · 2020-09-11T00:30:06Z

Ths is a manual cherry-pick of #436 and an additional commit to include a fallback mechanism to copy restore pod yaml from local disk, if the backup doesn't contain it.

This is done to support backups that were taken before the change to include restore-pod yaml in the static-pod-resources of etcd.

openshift-ci-robot · 2020-09-11T00:30:10Z

@retroflexer: This pull request references Bugzilla bug 1877930, which is invalid:

expected dependent Bugzilla bug 1837540 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.5] Bug 1877930: Use restore pod yaml from the backup when restoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bindata/etcd/cluster-restore.sh

hexfusion · 2020-09-11T12:22:00Z

/retest

hexfusion · 2020-09-11T13:58:13Z

/test e2e-aws-disruptive

hexfusion · 2020-09-11T18:42:59Z

/lgtm

hexfusion · 2020-09-11T18:43:43Z

/retest

hexfusion · 2020-09-11T20:35:52Z

cc @sdodson this bug helps in situations like 4.5 to 4.4 rollback.

openshift-bot · 2020-09-11T22:45:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-11T22:58:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-11T23:11:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

retroflexer · 2020-09-12T04:08:49Z

/retest

retroflexer · 2020-09-14T13:51:44Z

/retest

retroflexer · 2020-09-14T16:55:18Z

/test e2e-aws

bindata/etcd/cluster-restore.sh

hexfusion · 2020-09-14T19:59:44Z

/lgtm

openshift-ci-robot · 2020-09-14T20:00:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-22T01:01:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-22T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 1877930, which is invalid:

expected dependent Bugzilla bug 1837540 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-23T01:00:33Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-23T01:00:40Z

@openshift-bot: This pull request references Bugzilla bug 1877930, which is invalid:

expected dependent Bugzilla bug 1837540 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-24T01:00:30Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-24T01:00:42Z

@openshift-bot: This pull request references Bugzilla bug 1877930, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1837540 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1837540 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

markmc · 2020-09-24T13:27:42Z

(patch manager) seems like this addresses an important issue for users, and the risk of regression is mostly constrained to backup/restore itself

openshift-bot · 2020-09-24T15:44:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-24T18:45:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-24T20:02:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-24T20:15:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T00:22:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T02:45:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T03:24:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T05:47:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T06:53:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T07:18:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T09:54:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T10:08:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-25T22:15:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

knobunc · 2020-09-26T00:46:08Z

/retest

openshift-bot · 2020-09-26T00:52:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-26T01:17:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-26T01:43:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-26T02:58:33Z

@retroflexer: All pull requests linked via external trackers have merged:

openshift/cluster-etcd-operator#442

Bugzilla bug 1877930 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1877930: Use restore pod yaml from the backup when restoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Use restore pod yaml from the backup when restoring

3afd48b

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 11, 2020

openshift-ci-robot requested review from hexfusion and ironcladlou September 11, 2020 00:30

retroflexer mentioned this pull request Sep 11, 2020

[release-4.5] Bug 1877930: Use restore pod yaml from the backup when restoring #439

Closed

hexfusion reviewed Sep 11, 2020

View reviewed changes

bindata/etcd/cluster-restore.sh Show resolved Hide resolved

retroflexer mentioned this pull request Sep 11, 2020

[release-4.4] Bug 1877965: Use restore pod yaml from the backup when restoring #443

Merged

openshift-ci-robot assigned hexfusion Sep 11, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2020

Fallback on local copy if backup doesn't have restore pod yaml

f24fcc2

retroflexer force-pushed the extract-restore-pod-from-backup-4.5 branch from f76b8d3 to f24fcc2 Compare September 12, 2020 00:12

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2020

hexfusion reviewed Sep 14, 2020

View reviewed changes

bindata/etcd/cluster-restore.sh Show resolved Hide resolved

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 24, 2020

markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 24, 2020

openshift-merge-robot merged commit 0aa652d into openshift:release-4.5 Sep 26, 2020

retroflexer deleted the extract-restore-pod-from-backup-4.5 branch October 10, 2020 14:36

[release-4.5] Bug 1877930: Use restore pod yaml from the backup when restoring #442

[release-4.5] Bug 1877930: Use restore pod yaml from the backup when restoring #442

Conversation

retroflexer commented Sep 11, 2020

openshift-ci-robot commented Sep 11, 2020

hexfusion commented Sep 11, 2020

hexfusion commented Sep 11, 2020

hexfusion commented Sep 11, 2020

hexfusion commented Sep 11, 2020

hexfusion commented Sep 11, 2020

openshift-bot commented Sep 11, 2020

openshift-bot commented Sep 11, 2020

openshift-bot commented Sep 11, 2020

retroflexer commented Sep 12, 2020

retroflexer commented Sep 14, 2020

retroflexer commented Sep 14, 2020

hexfusion commented Sep 14, 2020

openshift-ci-robot commented Sep 14, 2020

openshift-bot commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

openshift-bot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

openshift-bot commented Sep 24, 2020

openshift-ci-robot commented Sep 24, 2020

markmc commented Sep 24, 2020

openshift-bot commented Sep 24, 2020

openshift-bot commented Sep 24, 2020

openshift-bot commented Sep 24, 2020

openshift-bot commented Sep 24, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

knobunc commented Sep 26, 2020

openshift-bot commented Sep 26, 2020

openshift-bot commented Sep 26, 2020

openshift-bot commented Sep 26, 2020

openshift-ci-robot commented Sep 26, 2020