Bug 1894267: Remove the rollbackcopier #494
Conversation
The rollbackcopier container exists to support a 4.4->4.5 upgrade. Once 4.5 is running, the container is no longer needed provided a 4.4 backup exists prior to the upgrade, which the rollbackcopier basically assures. The copier itself incurs a performance penalty that 4.5 users shouldn't be subject to once the upgrade is complete.
|
@ironcladlou: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
4.4 -> 4.5 upgrade test: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-gcp/1326211719902531584 /retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, ironcladlou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws-disruptive |
|
@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-aws-disruptive In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1894267, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sdodson this PR removes rollbackcopier from 4.5. The net gain is that the cluster does not perform snapshots every hour without users consent. We have seen some indications that these snapshots can lead to throttling events on certain providers. As this is already removed from 4.6 I am going to manually give greens on valid Bugzilla. |
hexfusion
added
bugzilla/valid-bug
|
Could there not be users that are relying on this behavior? It seems strange to completely remove a component in a z-stream. |
|
@ecordell this was undocumented thus not a supported feature so I would not expect folks to be relying on it. We implemented it as a fail-safe for 4.4 -> 4.5 upgrades. |
Anything's possible, but the facts are we have substantial evidence the function is causing performance problems for real users today, and we have no evidence of any users relying on it. If we became aware of users relying on it, we would be instructing them to cease relying upon it, and would feel justified in doing so because we never intended or communicated support for such uses in the first place. It was a single purpose tool to mitigate risk in a specific version upgrade, and beyond that it has only deleterious effects on a cluster. Hope that helps justify the change. |
|
4.4 -> 4.5 upgrades are still supported - is there some reason why this is no longer needed this as a fail-safe when upgrading to newer 4.5.z? |
|
@hexfusion and I spoke about this some, recording the discussion here:
a couple of options to move forward:
|
sdodson
added
the
cherry-pick-approved
|
cherry-pick-approved on @ecordell behalf as he's got permissions issues on this repo |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ironcladlou: All pull requests linked via external trackers have merged: Bugzilla bug 1894267 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The rollbackcopier container exists to support a 4.4->4.5 upgrade. Once
4.5 is running, the container is no longer needed provided a 4.4 backup
exists prior to the upgrade, which the rollbackcopier basically assures.
The copier itself incurs a performance penalty that 4.5 users shouldn't
be subject to once the upgrade is complete.