Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs #577

openshift-cherrypick-robot · 2021-04-27T03:15:31Z

This is an automated cherry-pick of #540

/assign marun

This refactor enables regenerating certs for nodes that have been removed and added back with the same name, and simplifies the addition of further checks for cert lineage and expiry.

marun · 2021-04-27T03:59:32Z

I've cherry-picked this fix in response to an issue reported against 4.7: #575

marun · 2021-04-27T04:20:09Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2021-04-27T04:20:10Z

@marun: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2021-04-27T11:59:16Z

/lgtm
/approve

openshift-ci-robot · 2021-04-27T11:59:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-27T12:02:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T12:15:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

marun · 2021-04-27T15:49:26Z

/retitle Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs

openshift-ci-robot · 2021-04-27T15:50:44Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1954121, which is invalid:

expected Bugzilla bug 1954121 to depend on a bug targeting a release in 4.8.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2021-04-27T16:04:34Z

/bugzilla refresh

openshift-ci-robot · 2021-04-27T16:04:38Z

@marun: This pull request references Bugzilla bug 1954121, which is invalid:

expected dependent Bugzilla bug 1954129 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-28T01:01:11Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-28T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 1954121, which is invalid:

expected dependent Bugzilla bug 1954129 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-29T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-29T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 1954121, which is invalid:

expected dependent Bugzilla bug 1954129 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-30T01:00:33Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-30T01:00:37Z

@openshift-bot: This pull request references Bugzilla bug 1954121, which is invalid:

expected dependent Bugzilla bug 1954129 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-01T01:00:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

marun · 2021-05-06T17:50:16Z

/bugzilla refresh

openshift-ci · 2021-05-06T17:50:20Z

@marun: This pull request references Bugzilla bug 1957640, which is invalid:

expected dependent Bugzilla bug 1954129 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2021-05-06T17:52:09Z

/bugzilla refresh

openshift-ci · 2021-05-06T17:52:16Z

@marun: This pull request references Bugzilla bug 1957640, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1954129 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1954129 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2021-05-06T19:34:29Z

/retitle Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs

openshift-ci · 2021-05-06T19:34:44Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alvaroaleman · 2021-05-06T19:51:52Z

/bugzilla refresh

openshift-ci · 2021-05-06T19:51:54Z

@alvaroaleman: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alvaroaleman · 2021-05-06T19:54:50Z

/retitle Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs

openshift-ci · 2021-05-06T19:56:12Z

@openshift-cherrypick-robot: An error was encountered querying GitHub for users with public email (geliu@redhat.com) for bug 1954121 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n  \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alvaroaleman · 2021-05-06T19:56:13Z

/bugzilla refresh

openshift-ci · 2021-05-06T19:56:17Z

@alvaroaleman: This pull request references Bugzilla bug 1954121, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1954129 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1954129 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-26T22:27:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-27T00:39:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-27T01:03:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-27T05:04:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-27T06:22:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-27T06:35:08Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-etcd-operator#577

Bugzilla bug 1954121 has been moved to the MODIFIED state.

In response to this:

Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-05-27T06:35:50Z

@marun: #577 failed to apply on top of branch "release-4.6":

Applying: Improve cert controller detection and correction of invalid certs
Using index info to reconstruct a base tree...
M	pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
A	pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go deleted in HEAD and modified in Improve cert controller detection and correction of invalid certs. Version Improve cert controller detection and correction of invalid certs of pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go left in tree.
Auto-merging pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
CONFLICT (content): Merge conflict in pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Improve cert controller detection and correction of invalid certs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Improve cert controller detection and correction of invalid certs

10adf32

This refactor enables regenerating certs for nodes that have been removed and added back with the same name, and simplifies the addition of further checks for cert lineage and expiry.

openshift-ci-robot assigned marun Apr 27, 2021

openshift-cherrypick-robot mentioned this pull request Apr 27, 2021

Improve cert controller detection and correction of invalid certs #540

Merged

openshift-ci-robot requested review from marun and retroflexer April 27, 2021 03:15

marun mentioned this pull request Apr 27, 2021

EtcdCertSignerController_Error due to secondary interface (added later) #575

Closed

openshift-ci-robot assigned hexfusion Apr 27, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021

openshift-ci-robot changed the title ~~[release-4.7] Improve cert controller detection and correction of invalid certs~~ Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs Apr 27, 2021

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 27, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 27, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 6, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 6, 2021

openshift-ci bot requested a review from geliu2016 May 6, 2021 17:52

openshift-ci bot changed the title ~~Bug 1957640: [release-4.7] Improve cert controller detection and correction of invalid certs~~ Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs May 6, 2021

openshift-ci bot removed the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 6, 2021

openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 6, 2021

openshift-ci bot changed the title ~~Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs~~ Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs May 6, 2021

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 6, 2021

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 26, 2021

openshift-merge-robot merged commit 7711c04 into openshift:release-4.7 May 27, 2021

Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs #577

Bug 1954121: [release-4.7] Improve cert controller detection and correction of invalid certs #577

Conversation

openshift-cherrypick-robot commented Apr 27, 2021

marun commented Apr 27, 2021

marun commented Apr 27, 2021

openshift-cherrypick-robot commented Apr 27, 2021

hexfusion commented Apr 27, 2021

openshift-ci-robot commented Apr 27, 2021

openshift-bot commented Apr 27, 2021

openshift-bot commented Apr 27, 2021

marun commented Apr 27, 2021

openshift-ci-robot commented Apr 27, 2021

marun commented Apr 27, 2021

openshift-ci-robot commented Apr 27, 2021

openshift-bot commented Apr 28, 2021

openshift-ci-robot commented Apr 28, 2021

openshift-bot commented Apr 29, 2021

openshift-ci-robot commented Apr 29, 2021

openshift-bot commented Apr 30, 2021

openshift-ci-robot commented Apr 30, 2021

openshift-bot commented May 1, 2021

marun commented May 6, 2021

openshift-ci bot commented May 6, 2021

marun commented May 6, 2021

openshift-ci bot commented May 6, 2021

marun commented May 6, 2021

openshift-ci bot commented May 6, 2021

alvaroaleman commented May 6, 2021

openshift-ci bot commented May 6, 2021

alvaroaleman commented May 6, 2021

openshift-ci bot commented May 6, 2021

alvaroaleman commented May 6, 2021

openshift-ci bot commented May 6, 2021

openshift-bot commented May 26, 2021

openshift-bot commented May 27, 2021

openshift-bot commented May 27, 2021

openshift-bot commented May 27, 2021

openshift-bot commented May 27, 2021

openshift-ci bot commented May 27, 2021

openshift-cherrypick-robot commented May 27, 2021