-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1955418: manifests: Shift FlowSchema to level 50 #582
Bug 1955418: manifests: Shift FlowSchema to level 50 #582
Conversation
This moves us behind the Kube API-server, like some other FlowSchema: $ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.7.9-x86_64 $ ls manifests/*kube-apiserver*deployment* manifests/0000_20_kube-apiserver-operator_06_deployment.yaml $ grep -4r FlowSchema manifests | grep apiVersion | sort manifests/0000_12_etcd-operator_10_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_20_kube-apiserver-operator_08_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_20_kube-apiserver-operator_08_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_30_openshift-apiserver-operator_09_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_30_openshift-apiserver-operator_09_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_30_openshift-apiserver-operator_09_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_50_cluster-authentication-operator_09_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_50_cluster-authentication-operator_09_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_50_cluster-authentication-operator_09_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_50_cluster-authentication-operator_09_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 manifests/0000_50_cluster-openshift-controller-manager-operator_10_flowschema.yaml-apiVersion: flowcontrol.apiserver.k8s.io/v1alpha1 That fixes a 4.7 v1alpha1 manifest vs. 4.8 v1beta1-only API-server on 4.8 -> 4.7 rollbacks [1]. We could also bump to v1beta1 like master/4.8's 7f76a91 (switch to v1beta1 for the p&f APIs, 2021-01-06, openshift#516), but I don't think we need to, and as you can see in the grep there are lots of other v1alpha1 FlowSchema in 4.7, so I'm leaving that off for now. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1955414
@wking: This pull request references Bugzilla bug 1955418, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm /retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
18 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1955418, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold Enough of the CI jobs have passed for this to merge, once QE verifies that 4.8->4.8 rollbacks are working and the patch-manager approves the cherry-pick. No need to keep retesting while we wait on those. |
/bugzilla refresh |
@wking: This pull request references Bugzilla bug 1955418, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: geliu2016. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/skip |
/retest Please review the full test history for this PR and help us cut down flakes. |
/override ci/prow/e2e-gcp-five-control-plane-replicas not supported in 4.7 failure was interrupt after 2m |
@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 1955418 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
(like #581, but against the correct release-4.7, instead of #581's master)
This moves us behind the Kube API-server, like some other FlowSchema:
That fixes a 4.7 v1alpha1 manifest vs. 4.8 v1beta1-only API-server on 4.8 -> 4.7 rollbacks.
We could also bump to v1beta1 like master/4.8's 7f76a91 (#516), but I don't think we need to, and as you can see in the grep there are lots of other v1alpha1 FlowSchema in 4.7, so I'm leaving that off for now.