[release-4.7] Bug 1958416: pkg/dnshelpers: fallback to spec if status is not populated for serviceNetwork #594

retroflexer · 2021-05-13T01:05:24Z

Manual cherry-pick of #587 and #591.

…ceNetwork Signed-off-by: Sam Batschelet <sbatsche@redhat.com>

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>

openshift-ci · 2021-05-13T01:05:28Z

@retroflexer: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

retroflexer · 2021-05-13T01:06:50Z

/bugzilla refresh

openshift-ci · 2021-05-13T01:06:54Z

@retroflexer: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2021-05-13T11:46:06Z

/approve

hexfusion · 2021-05-13T11:54:25Z

/lgtm

openshift-ci · 2021-05-13T11:54:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-05-14T01:00:43Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-14T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-15T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-15T01:01:03Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-16T01:00:53Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-16T01:00:57Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-17T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-17T01:01:02Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-18T01:00:56Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-18T01:01:00Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-19T01:01:02Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-19T01:01:06Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-20T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-20T01:00:41Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-21T01:01:16Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-bot · 2021-05-23T01:00:41Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-23T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-24T01:00:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-24T01:00:46Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-25T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-25T01:00:51Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-26T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-26T01:00:53Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-27T01:00:30Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-27T01:00:34Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-28T01:00:51Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-28T01:00:55Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-29T01:00:41Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-29T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-30T01:00:43Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-30T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-31T01:00:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-31T01:00:46Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-06-01T01:00:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-06-01T01:00:29Z

@openshift-bot: This pull request references Bugzilla bug 1958416, which is invalid:

expected dependent Bugzilla bug 1902247 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

retroflexer · 2021-06-01T20:05:14Z

/bugzilla refresh

openshift-ci · 2021-06-01T20:05:23Z

@retroflexer: This pull request references Bugzilla bug 1958416, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1902247 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1902247 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @geliu2016

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekwaynecarr · 2021-06-03T21:47:50Z

[patch-manager] 🚀 Approved for z-stream by score: 0.20

approved

openshift-ci · 2021-06-03T23:53:07Z

@retroflexer: All pull requests linked via external trackers have merged:

openshift/cluster-etcd-operator#594

Bugzilla bug 1958416 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion added 2 commits May 12, 2021 20:58

pkg/dnshelpers: fallback to spec if status is not populated for servi…

d61d98a

…ceNetwork Signed-off-by: Sam Batschelet <sbatsche@redhat.com>

pkg/dnshelpers: cleanup dead code

5cd9fda

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 13, 2021

openshift-ci bot requested review from hexfusion and marun May 13, 2021 01:05

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021

openshift-ci bot assigned hexfusion May 13, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 1, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 1, 2021

openshift-ci bot requested a review from geliu2016 June 1, 2021 20:05

derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 3, 2021

openshift-merge-robot merged commit 0859586 into openshift:release-4.7 Jun 3, 2021

retroflexer deleted the fix-util-4.7 branch June 4, 2021 21:16

[release-4.7] Bug 1958416: pkg/dnshelpers: fallback to spec if status is not populated for serviceNetwork #594

[release-4.7] Bug 1958416: pkg/dnshelpers: fallback to spec if status is not populated for serviceNetwork #594

Conversation

retroflexer commented May 13, 2021

openshift-ci bot commented May 13, 2021

retroflexer commented May 13, 2021

openshift-ci bot commented May 13, 2021

hexfusion commented May 13, 2021

hexfusion commented May 13, 2021

openshift-ci bot commented May 13, 2021

openshift-bot commented May 14, 2021

openshift-ci bot commented May 14, 2021

openshift-bot commented May 15, 2021

openshift-ci bot commented May 15, 2021

openshift-bot commented May 16, 2021

openshift-ci bot commented May 16, 2021

openshift-bot commented May 17, 2021

openshift-ci bot commented May 17, 2021

openshift-bot commented May 18, 2021

openshift-ci bot commented May 18, 2021

openshift-bot commented May 19, 2021

openshift-ci bot commented May 19, 2021

openshift-bot commented May 20, 2021

openshift-ci bot commented May 20, 2021

openshift-bot commented May 21, 2021

openshift-bot commented May 23, 2021

openshift-ci bot commented May 23, 2021

openshift-bot commented May 24, 2021

openshift-ci bot commented May 24, 2021

openshift-bot commented May 25, 2021

openshift-ci bot commented May 25, 2021

openshift-bot commented May 26, 2021

openshift-ci bot commented May 26, 2021

openshift-bot commented May 27, 2021

openshift-ci bot commented May 27, 2021

openshift-bot commented May 28, 2021

openshift-ci bot commented May 28, 2021

openshift-bot commented May 29, 2021

openshift-ci bot commented May 29, 2021

openshift-bot commented May 30, 2021

openshift-ci bot commented May 30, 2021

openshift-bot commented May 31, 2021

openshift-ci bot commented May 31, 2021

openshift-bot commented Jun 1, 2021

openshift-ci bot commented Jun 1, 2021

retroflexer commented Jun 1, 2021

openshift-ci bot commented Jun 1, 2021

derekwaynecarr commented Jun 3, 2021

openshift-ci bot commented Jun 3, 2021