Bug 1701154: Enable etcdHighNumberOfFailedGRPCRequests alerts #626
Conversation
|
/approve |
openshift-ci
bot
added
lgtm
|
/hold We need a patch. |
openshift-ci
bot
added
do-not-merge/hold
|
cc @lilic bummer :) |
openshift-ci
bot
removed
lgtm
| description: 'etcd cluster "{{ $labels.job }}": {{ $value }}% of requests | ||
| for {{ $labels.grpc_method }} failed on etcd instance {{ $labels.instance | ||
| }}.' | ||
| runbook_url: https://github.com/openshift/runbooks/blob/master/alerts/etcdHighNumberOfFailedGRPCRequests.md |
There was a problem hiding this comment.
We still need to write this, will do it once the alert is merged.
|
/retest |
|
Since we have etcd 3.5 now, we are ready to merge this. The only thing that fails is unrelated to this, its the PV test. /hold cancel @hexfusion please take a look again, thanks! |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/e2e-gcp-five-control-plane-replicas |
|
@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, lilic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lilic
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@lilic: This pull request references Bugzilla bug 1701154, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@lilic: This pull request references Bugzilla bug 1701154, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-gcp-five-control-plane-replicas |
|
@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@lilic: All pull requests linked via external trackers have merged: Bugzilla bug 1701154 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was fixed upstream, let's enable it downstream now as well. 🤞