Bug 1997347: ETCD-223: pkg/operator: add cluster backup upgrade controller

[hexfusion]

Signed-off-by: Sam Batschelet sbatsche@redhat.com

[wking]

/retitle Bug 1997347: ETCD-223: pkg/operator: add cluster backup upgrade controller

[openshift-ci]

@hexfusion: An error was encountered querying GitHub for users with public email (geliu@redhat.com) for bug 1997347 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1997347: ETCD-223: pkg/operator: add cluster backup upgrade controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lilic]

Couple of comments. As mentioned before overall idea lgtm, I would just like to see this in 4.8 first but think it was discussed on slack already.

One other thing that would be great here is:

• adding metric for failed backups
• creating alert if this backup fails

Are we blocking upgrades if this fails or we do not have the backup?

[hexfusion]

/hold cancel

[hexfusion]

/override ci/prow/e2e-gcp-five-control-plane-replicas

[openshift-ci]

@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas

In response to this:

/override ci/prow/e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lilic]

Couple of questions, must have mixed it on initial review.

[lilic]

Nit: new line not needed?

[lilic]

/lgtm
/approve

🎉

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, lilic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hexfusion]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@hexfusion: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

/override ci/prow/e2e-gcp-five-control-plane-replicas

[openshift-ci]

@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas

In response to this:

/override ci/prow/e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

/test e2e-agnostic-upgrade

[hexfusion]

/override ci/prow/e2e-gcp-five-control-plane-replicas

[openshift-ci]

@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas

In response to this:

/override ci/prow/e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@hexfusion: All pull requests linked via external trackers have merged:

• openshift/cluster-etcd-operator#647
• openshift/cluster-version-operator#637

Bugzilla bug 1997347 has been moved to the MODIFIED state.

In response to this:

Bug 1997347: ETCD-223: pkg/operator: add cluster backup upgrade controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@hexfusion: #647 failed to apply on top of branch "release-4.8":

Applying: pkg/operator: add cluster backup upgrade controller
.git/rebase-apply/patch:104: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	pkg/etcdcli/etcdcli.go
M	pkg/etcdcli/helpers.go
M	pkg/etcdcli/interfaces.go
A	pkg/operator/defragcontroller/defragcontroller.go
M	pkg/operator/etcd_assets/bindata.go
M	pkg/operator/starter.go
M	pkg/testutils/testutils.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/testutils/testutils.go
CONFLICT (content): Merge conflict in pkg/testutils/testutils.go
Auto-merging pkg/operator/starter.go
CONFLICT (content): Merge conflict in pkg/operator/starter.go
Auto-merging pkg/operator/etcd_assets/bindata.go
CONFLICT (modify/delete): pkg/operator/defragcontroller/defragcontroller.go deleted in HEAD and modified in pkg/operator: add cluster backup upgrade controller. Version pkg/operator: add cluster backup upgrade controller of pkg/operator/defragcontroller/defragcontroller.go left in tree.
Auto-merging pkg/etcdcli/interfaces.go
CONFLICT (content): Merge conflict in pkg/etcdcli/interfaces.go
Auto-merging pkg/etcdcli/helpers.go
CONFLICT (content): Merge conflict in pkg/etcdcli/helpers.go
Auto-merging pkg/etcdcli/etcdcli.go
CONFLICT (content): Merge conflict in pkg/etcdcli/etcdcli.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 pkg/operator: add cluster backup upgrade controller
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.