Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1997347: pkg/operator/upgradebackupcontroller: update cluster operator status #653

Merged
merged 1 commit into from Sep 1, 2021

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Sep 1, 2021

This PR fixes an issue with the backup controller where CVO was looking for status reported to ClusterOperator config.openshift.io/v1 but instead, we were publishing to operator.openshift.io/v1.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@wking
Copy link
Member

wking commented Sep 1, 2021

/retitle Bug 1997347: pkg/operator/upgradebackupcontroller: update cluster operator status

@openshift-ci openshift-ci bot changed the title pkg/operator/upgradebackupcontroller: update cluster operator status Bug 1997347: pkg/operator/upgradebackupcontroller: update cluster operator status Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@hexfusion: This pull request references Bugzilla bug 1997347, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

Bug 1997347: pkg/operator/upgradebackupcontroller: update cluster operator status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 1, 2021
@hexfusion
Copy link
Contributor Author

/skip

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Contributor Author

/skip
/override ci/prow/e2e-gcp-five-control-plane-replicas

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas

In response to this:

/skip
/override ci/prow/e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@hexfusion
Copy link
Contributor Author

Self tagging after manual local testing.

Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, lilic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilic
Copy link
Contributor

lilic commented Sep 1, 2021

/override e2e-gcp-five-control-plane-replicas

Is it not like this?

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@lilic: lilic unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override e2e-gcp-five-control-plane-replicas

Is it not like this?

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor Author

/override e2e-gcp-five-control-plane-replicas

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@hexfusion: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • e2e-gcp-five-control-plane-replicas

Only the following contexts were expected:

  • ci/prow/e2e-agnostic
  • ci/prow/e2e-agnostic-upgrade
  • ci/prow/e2e-aws-single-node
  • ci/prow/e2e-gcp-five-control-plane-replicas
  • ci/prow/e2e-operator
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • pull-ci-openshift-cluster-etcd-operator-release-4.2-images
  • pull-ci-openshift-cluster-etcd-operator-release-4.2-unit
  • pull-ci-openshift-cluster-etcd-operator-release-4.2-verify
  • pull-ci-openshift-cluster-etcd-operator-release-4.2-verify-deps
  • pull-ci-openshift-cluster-etcd-operator-release-4.4-e2e-agnostic-upgrade
  • pull-ci-openshift-cluster-etcd-operator-release-4.6-e2e-agnostic
  • pull-ci-openshift-cluster-etcd-operator-release-4.6-e2e-operator
  • pull-ci-openshift-cluster-etcd-operator-release-4.8-e2e-aws-single-node
  • pull-ci-openshift-cluster-etcd-operator-release-4.8-e2e-gcp-five-control-plane-replicas
  • tide

In response to this:

/override e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Sep 1, 2021

/override ci/prow/e2e-gcp-five-control-plane-replicas

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@mfojtik: mfojtik unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@mfojtik: mfojtik unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override ci/prow/e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

/override ci/prow/e2e-gcp-five-control-plane-replicas

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@hexfusion: Overrode contexts on behalf of hexfusion: ci/prow/e2e-gcp-five-control-plane-replicas

In response to this:

/override ci/prow/e2e-gcp-five-control-plane-replicas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 62df7c1 into openshift:master Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@hexfusion: All pull requests linked via external trackers have merged:

Bugzilla bug 1997347 has been moved to the MODIFIED state.

In response to this:

Bug 1997347: pkg/operator/upgradebackupcontroller: update cluster operator status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants