Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/operator/defragcontroller: ensure defrag controller is disabled for non HA tolopogy #711

Merged
merged 2 commits into from
Nov 30, 2021
Merged

pkg/operator/defragcontroller: ensure defrag controller is disabled for non HA tolopogy #711

merged 2 commits into from
Nov 30, 2021

Conversation

hexfusion
Copy link
Contributor

Due to an unfortunate series of events we have missed the fact that defrag is not properly disabled for non HA clusters. Because integration tests were using BeforeTest vs BeforeTestExternal it actually skipped the test... This PR resolves the test failure as well as properly gates the controller against non HA usage...

=== RUN   TestNewDefragController
--- PASS: TestNewDefragController (0.26s)
=== RUN   TestNewDefragController/defrag_success
    leak.go:102: Found leaked goroutined BEFORE test appears to have leaked :
        k8s.io/klog/v2.(*loggingT).flushDaemon(0x0)
        	/home/remote/sbatsche/projects/openshift/cluster-etcd-operator/vendor/k8s.io/klog/v2/klog.go:1169 +0x6a
        created by k8s.io/klog/v2.init.0
        	/home/remote/sbatsche/projects/openshift/cluster-etcd-operator/vendor/k8s.io/klog/v2/klog.go:420 +0xfb
    --- SKIP: TestNewDefragController/defrag_success (0.05s)
    ```

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@hexfusion
pkg/operator/defragcontroller: ensure defrag controller is disabled f…
c14d5df 
…or non HA tolopogy

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
pkg/operator/defragcontroller: use BeforeTestExternal for etcd integr…
82008db 
…ation pkg

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Contributor Author

cc @romfreiman 🤦‍♂️

hasbro17
hasbro17 approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
@hexfusion
Copy link
Contributor Author

infra

/test e2e-agnostic

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021 •
edited
Loading

@hexfusion: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-five-control-plane-replicas 82008db link false /test e2e-gcp-five-control-plane-replicas

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8433304 into openshift:master Nov 30, 2021
@hexfusion hexfusion deleted the fix-sno-defrag branch November 30, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 approved these changes

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@marun marun Awaiting requested review from marun

Assignees

@hasbro17 hasbro17

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hexfusion @openshift-bot @hasbro17 @openshift-merge-robot