Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds attemptToRemoveLearningMember to the cluster member removal controller #784

Merged
merged 1 commit into from
Apr 9, 2022
Merged

adds attemptToRemoveLearningMember to the cluster member removal controller #784

merged 1 commit into from
Apr 9, 2022

Conversation

p0lyn0mial
Copy link
Contributor

it attempts to remove a learning member pending deletion regardless of whether a replacement member has been found

@openshift-ci openshift-ci bot requested review from ironcladlou and marun April 8, 2022 10:44
@p0lyn0mial
Copy link
Contributor Author

/assign @hasbro17 @deads2k

@p0lyn0mial
adds attemptToRemoveLearningMember to the cluster member removal cont…
b13fbe6 
…roller

it attempts to remove a learning member pending deletion regardless of whether a replacement member has been found
@deads2k
Copy link
Contributor

deads2k commented Apr 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 9, 2022

@p0lyn0mial: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-five-control-plane-replicas b13fbe6 link false /test e2e-gcp-five-control-plane-replicas

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4c712fe into openshift:master Apr 9, 2022
@hardys hardys mentioned this pull request Apr 12, 2022
Closed
hardys pushed a commit to hardys/cluster-etcd-operator that referenced this pull request Apr 12, 2022
Fix ipv6 node lookup in clustermemberremovalcontroller
a74c632 
The changes in openshift#784 only work for ipv4
hardys pushed a commit to hardys/cluster-etcd-operator that referenced this pull request Apr 12, 2022
Fix ipv6 node lookup in clustermemberremovalcontroller
880b5e8 
The changes in openshift#784 only work for ipv4
@hardys hardys mentioned this pull request Apr 13, 2022
Merged
deads2k added a commit that referenced this pull request Apr 13, 2022
@deads2k
Merge pull request #786 from hardys/780_revert
cff44a1 
Bug 2074544 : revert #784 and #780 to fix ipv6
p0lyn0mial pushed a commit to p0lyn0mial/cluster-etcd-operator that referenced this pull request Apr 13, 2022
@p0lyn0mial
Fix ipv6 node lookup in clustermemberremovalcontroller
d0bacf8 
The changes in openshift#784 only work for ipv4
p0lyn0mial pushed a commit to p0lyn0mial/cluster-etcd-operator that referenced this pull request Apr 14, 2022
@p0lyn0mial
Fix ipv6 node lookup in clustermemberremovalcontroller
81e97df 
The changes in openshift#784 only work for ipv4
@p0lyn0mial p0lyn0mial mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@marun marun Awaiting requested review from marun

Assignees

@hasbro17 hasbro17

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@p0lyn0mial @deads2k @openshift-bot @hasbro17 @openshift-merge-robot