Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypershift: Stop trying to apply etcd prometheusrule #917

Merged
merged 1 commit into from Oct 10, 2022
Merged

Hypershift: Stop trying to apply etcd prometheusrule #917

merged 1 commit into from Oct 10, 2022

Conversation

alvaroaleman
Copy link
Contributor

This never had any targets in Hypershift so it is pointless. Since
b4537b9 it started to cause errors,
because the namespace isn't applied anymore:

  - lastTransitionTime: "2022-08-26T17:09:57Z"
    message: 'Could not update prometheusrule "openshift-etcd-operator/etcd-prometheus-rules"
      (537 of 566): resource may have been deleted'

We currently worked around this in Hypershift itself by deleting that
manifest, but that is not a great solution: openshift/hypershift@2c927d9

/assign Elbehery
/cc @tjungblu

@alvaroaleman
Hypershift: Stop trying to apply etcd prometheusrule
106100b 
This never had any targets in Hypershift so it is pointless. Since
b4537b9 it started to cause errors,
because the namespace isn't applied anymore:
```
  - lastTransitionTime: "2022-08-26T17:09:57Z"
    message: 'Could not update prometheusrule "openshift-etcd-operator/etcd-prometheus-rules"
      (537 of 566): resource may have been deleted'
```

We currently worked around this in Hypershift itself by deleting that
manifest, but that is not a great solution: openshift/hypershift@2c927d9
@openshift-ci openshift-ci bot requested a review from tjungblu August 26, 2022 19:04
@alvaroaleman alvaroaleman mentioned this pull request Aug 26, 2022
Merged
@Elbehery
Copy link
Contributor

Elbehery commented Sep 5, 2022

/retest

2 similar comments
@Elbehery
Copy link
Contributor

Elbehery commented Sep 5, 2022

/retest

@Elbehery
Copy link
Contributor

Elbehery commented Sep 6, 2022

/retest

@Elbehery
Copy link
Contributor

Elbehery commented Sep 7, 2022

/retest-required

1 similar comment
@Elbehery
Copy link
Contributor

Elbehery commented Sep 7, 2022

/retest-required

@tjungblu
Copy link
Contributor

/lgtm

@dusk125 mind to approve?

@tjungblu
Copy link
Contributor

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@dusk125
Copy link
Contributor

dusk125 commented Sep 28, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@tjungblu
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ac362e9 and 2 for PR HEAD 106100b in total

@tjungblu
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5324048 and 1 for PR HEAD 106100b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b561d08 and 0 for PR HEAD 106100b in total

@openshift-ci-robot
Copy link

/hold

Revision 106100b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@tjungblu
Copy link
Contributor

/hold cancel

@tjungblu
Copy link
Contributor

/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022 •
edited

@alvaroaleman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 106100b link true /test e2e-aws-single-node
ci/prow/e2e-gcp-ovn-five-control-plane-replicas 106100b link false /test e2e-gcp-ovn-five-control-plane-replicas

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tjungblu
Copy link
Contributor

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 17238fb into openshift:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjungblu tjungblu Awaiting requested review from tjungblu

Assignees

@Elbehery Elbehery

@tjungblu tjungblu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alvaroaleman @Elbehery @tjungblu @dusk125 @openshift-ci-robot @openshift-merge-robot