Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Get calls to use the lister cache #156

Merged
merged 4 commits into from
Jan 31, 2019
Merged

Update Get calls to use the lister cache #156

merged 4 commits into from
Jan 31, 2019

Conversation

coreydaley
Copy link
Member

@coreydaley coreydaley commented Jan 15, 2019 •
edited

Updates all(most) Get calls to use the lister cache.
ClusterVersion and ClusterOperator are excluded as they provided a steady stream of events which caused a hotloop like issue of constant events being processed.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 15, 2019
@coreydaley coreydaley requested review from bparees and legionus and removed request for smarterclayton January 15, 2019 18:26
@coreydaley coreydaley changed the title [WIP] Update all Get calls to use the lister cache Update all Get calls to use the lister cache Jan 15, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2019
@coreydaley coreydaley changed the title Update all Get calls to use the lister cache Update all(most) Get calls to use the lister cache Jan 15, 2019
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

coreydaley commented Jan 15, 2019 •
edited

/hold waiting for review

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2019
@coreydaley
Copy link
Member Author

/retest

1 similar comment
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

@bparees @legionus @dmage ptal

@coreydaley
Copy link
Member Author

/retest

bparees
bparees requested changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@bparees bparees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits, mostly lgtm though i'm slightly wary of whether this causes us problems in cases where the cache is not yet updated and thus our get fails (whereas the real api call would have succeeded).

hopefully our resync behavior is sufficient to resolve any temporary problems caused by such a thing.

in my ideal world we'd have a read-through cache though (attempt an api get if the cache get is a miss). Still doesn't address stale reads, but at least it would resolve straight up missing object cases.

pkg/clusterconfig/clusterconfig.go Outdated Show resolved Hide resolved
pkg/operator/controller.go Outdated Show resolved Hide resolved
pkg/testframework/mock/listers/configmaps.go Outdated Show resolved Hide resolved
@coreydaley
Copy link
Member Author

@bparees ptal
Updates made per your feedback in a separate commit.
95e5500

@coreydaley
Copy link
Member Author

/retest

1 similar comment
@coreydaley
Copy link
Member Author

/retest

@bparees
Copy link
Contributor

bparees commented Jan 15, 2019

lgtm, let's see what @legionus and @dmage have to say.

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Update Get calls to use the lister cache
aa98112 
Updates  Get calls to use the lister cache.
ClusterVersion and ClusterOperator are excluded as they provided a steady stream of events which caused a hotloop like issue of constant events being processed.
@coreydaley
Updates per comments from Ben 001
948d33a
@coreydaley
Updates per comments from Ben 002
b9500c4
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2019
bparees
bparees requested changes Jan 29, 2019
View reviewed changes
pkg/client/client.go Outdated Show resolved Hide resolved
pkg/resource/utils.go Outdated Show resolved Hide resolved
test/e2e/basic_empty_dir_test.go Outdated Show resolved Hide resolved
@bparees
Copy link
Contributor

bparees commented Jan 29, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@coreydaley
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/test e2e-aws-operator

@coreydaley
Copy link
Member Author

/retest

8 similar comments
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 452e076 into openshift:master Jan 31, 2019
@coreydaley coreydaley deleted the use_caches_for_get branch August 14, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage dmage left review comments

@bparees bparees bparees requested changes

@legionus legionus Awaiting requested review from legionus

Assignees

@dmage dmage

@legionus legionus

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@coreydaley @bparees @dmage @openshift-ci-robot @openshift-bot @legionus @openshift-merge-robot