OpenStack: set container metadata #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
coreydaley
reviewed
Aug 1, 2019
coreydaley
reviewed
Aug 1, 2019
coreydaley
reviewed
Aug 1, 2019
This commit adds metadata to the generated Swift image registry container to allow Terraform to delete it at the time the cluster is destroyed. Also it changes the format of container naming in Swift: <clusterID>-image-registry-<8_random_letters>, which is common for all resources created by Terraform.
coreydaley
reviewed
Aug 5, 2019
|
On second thought, why don't we go ahead and get this merged, then I am going to refactor the storage bucket/container name creation to all use a common function so we can be consistent, and I will add the retry at that time for swift. |
|
/lgtm /assign @adambkaplan |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, coreydaley, Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds metadata to the generated Swift image registry container to allow Terraform to delete it at the time the cluster is destroyed.
Also it changes the format of container naming in Swift:
-image-registry-<8_random_letters>, which is common for all resources created by Terraform.
Fixes: #317