Bug 1753778: Set Version on Operator status even if Removed. #406
Conversation
ricardomaraschini
changed the title
openshift-ci-robot
added
do-not-merge/work-in-progress
ricardomaraschini
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@ricardomaraschini: This pull request references Bugzilla bug 1768357, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @dmage @adambkaplan |
There was a problem hiding this comment.
@ricardomaraschini also needs a test to verify (unit is fine).
|
/test e2e-aws |
openshift-ci-robot
added
size/L
|
@adambkaplan I have implemented unit testing for the |
|
/test unit |
|
/test verify |
|
/test unit |
ricardomaraschini
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retitle Bug 1753778,1768357: Set Version on Operator status even if Removed. |
openshift-ci-robot
changed the title
openshift-ci-robot
removed
the
bugzilla/valid-bug
|
@ricardomaraschini: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1753778, 1768357: Set Version on Operator status even if Removed. |
openshift-ci-robot
changed the title
|
/bugzilla refresh |
|
@adambkaplan: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1753778: Set Version on Operator status even if Removed. |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@ricardomaraschini: This pull request references Bugzilla bug 1753778, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This patch uses the environment variable RELEASE_VERSION to set Operator version if ManagementState is not "Managed". This is introduced now as we may, in some situations, bootstrap the Image Registry Operator with Removed ManagementState.
|
@ricardomaraschini: This pull request references Bugzilla bug 1753778, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.2 |
|
@ricardomaraschini: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.1 |
|
@ricardomaraschini: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws-image-registry |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@ricardomaraschini: All pull requests linked via external trackers have merged. Bugzilla bug 1753778 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ricardomaraschini: new pull request created: #408 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ricardomaraschini: new pull request created: #409 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This patch uses the environment variable RELEASE_VERSION to set Operator
version if ManagementState is not "Managed". This is introduced now as we
may, in some situations, bootstrap the Image Registry Operator with Removed
ManagementState.