Bug 1769927: Persistent Deployment #451
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@ricardomaraschini: This pull request references Bugzilla bug 1769927, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XXL
|
/retest |
|
@ricardomaraschini: This pull request references Bugzilla bug 1769927, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
/assign @dmage @adambkaplan |
ricardomaraschini
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@ricardomaraschini why do we need to bump dependencies in this PR? |
|
@ricardomaraschini can you write an e2e test that patches the registry deployment and checks that this change is stomped? |
|
/approve |
openshift-ci-robot
added
the
approved
It happened when i added the new dependency on |
Yes. |
|
@dmage test implemented, PTAL. |
test/e2e/recreate_deployment_test.go
Outdated
| } | ||
|
|
||
| // give some room for the operator to restore the deployment. | ||
| time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
It's better to watch the resource. Or at least to poll. You never know how slow the CI machine can be.
There was a problem hiding this comment.
I added a Poll here, PTAL.
This patch makes use of library-go ApplyDeployment() function to stomp over user provided changes. This way we ensure that image registry Deployment is always on the state we need it to be.
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch makes use of library-go ApplyDeployment() function to stomp over user provided changes. This way we ensure that image registry Deployment is always on the state we need it to be.