WIP - Bug 1769927: Persistent Deployment #448
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@ricardomaraschini: This pull request references Bugzilla bug 1769927, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardomaraschini The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| return unexportedVar.MatchString(last) || last == ".DefaultMode" | ||
| } | ||
|
|
||
| if cmp.Equal(exp.Spec, cur.Spec, cmp.FilterPath(ignore, cmp.Ignore())) { |
There was a problem hiding this comment.
I'd prefer to check the deployment's Generation instead of guessing what can be defaulted in the deployment.
|
@ricardomaraschini: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this PR as a new(#451) one has been created with a different approach. |
With this patch Operator starts to stomp on user made changes on image-registry deployment.