Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1776665: Remove watch for KubeSystem ConfigMaps #470

Merged
merged 1 commit into from Feb 28, 2020
Merged

Bug 1776665: Remove watch for KubeSystem ConfigMaps #470

merged 1 commit into from Feb 28, 2020

Conversation

coreydaley
Copy link
Member

We should no longer rely on the installConfig configmap in the kubesystem.
Removing the watch for the kubesystem configmaps will fix the out of control
event processing every 4 seconds

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

@coreydaley: This pull request references Bugzilla bug 1776665, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1776665: Remove watch for KubeSystem ConfigMaps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 27, 2020
@coreydaley
Copy link
Member Author

/retest

pkg/storage/util/util.go Show resolved Hide resolved
pkg/operator/controller.go Show resolved Hide resolved
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

We should no longer rely on the installConfig configmap in the kubesystem.
Removing the watch for the kubesystem configmaps will fix the out of control
event processing every 4 seconds
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@coreydaley
Copy link
Member Author

/retest

@coreydaley
Copy link
Member Author

@adambkaplan @dmage Can i get another lgtm? I had to make a small change.

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@adambkaplan
Copy link
Contributor

/cherrypick release-4.4

@openshift-cherrypick-robot

@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

/cherrypick release-4.3

@openshift-cherrypick-robot

@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 413a4a2 into openshift:master Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

@coreydaley: All pull requests linked via external trackers have merged. Bugzilla bug 1776665 has been moved to the MODIFIED state.

In response to this:

Bug 1776665: Remove watch for KubeSystem ConfigMaps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adambkaplan: new pull request created: #471

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adambkaplan: #470 failed to apply on top of branch "release-4.3":

Using index info to reconstruct a base tree...
M	pkg/client/fake/fixtures.go
M	pkg/client/listers.go
M	pkg/operator/bootstrap.go
M	pkg/operator/controller.go
M	pkg/storage/azure/azure.go
M	pkg/storage/gcs/gcs.go
M	pkg/storage/s3/s3.go
M	pkg/storage/storage.go
M	pkg/storage/swift/swift.go
M	pkg/storage/util/util.go
M	test/e2e/aws_test.go
M	test/e2e/gcs_test.go
M	test/framework/mock/listers/listers.go
Falling back to patching base and 3-way merge...
Auto-merging test/framework/mock/listers/listers.go
Auto-merging test/e2e/gcs_test.go
Auto-merging test/e2e/aws_test.go
CONFLICT (content): Merge conflict in test/e2e/aws_test.go
Auto-merging pkg/storage/util/util.go
CONFLICT (content): Merge conflict in pkg/storage/util/util.go
Auto-merging pkg/storage/swift/swift.go
Auto-merging pkg/storage/storage.go
Auto-merging pkg/storage/s3/s3.go
Auto-merging pkg/storage/gcs/gcs.go
Auto-merging pkg/storage/azure/azure.go
Auto-merging pkg/operator/controller.go
CONFLICT (content): Merge conflict in pkg/operator/controller.go
Auto-merging pkg/operator/bootstrap.go
CONFLICT (content): Merge conflict in pkg/operator/bootstrap.go
Auto-merging pkg/client/listers.go
CONFLICT (content): Merge conflict in pkg/client/listers.go
Auto-merging pkg/client/fake/fixtures.go
error: Failed to merge in the changes.
Patch failed at 0001 Remove watch for KubeSystem ConfigMaps

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants